Skip to content

ARROW-5388: [Go] use arrow.TypeEquals in array.NewChunked #4362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

ARROW-5388: [Go] use arrow.TypeEquals in array.NewChunked #4362

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go/arrow/array/table.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ func NewChunked(dtype arrow.DataType, chunks []Interface) *Chunked {
dtype: dtype,
}
for i, chunk := range chunks {
if chunk.DataType() != dtype {
if !arrow.TypeEquals(chunk.DataType(), dtype) {
panic("arrow/array: mismatch data type")
}
chunk.Retain()
Expand Down
22 changes: 22 additions & 0 deletions go/arrow/array/table_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,28 @@ func TestChunked(t *testing.T) {
}
}

func TestChunkedEqualDataType(t *testing.T) {
mem := memory.NewCheckedAllocator(memory.NewGoAllocator())
defer mem.AssertSize(t, 0)

lb1 := array.NewListBuilder(mem, arrow.PrimitiveTypes.Int32)
defer lb1.Release()

v1 := lb1.NewArray()
defer v1.Release()

lb2 := array.NewListBuilder(mem, arrow.PrimitiveTypes.Int32)
defer lb2.Release()

v2 := lb2.NewArray()
defer v2.Release()

c1 := array.NewChunked(arrow.ListOf(arrow.PrimitiveTypes.Int32), []array.Interface{
v1, v2,
})
defer c1.Release()
}

func TestChunkedInvalid(t *testing.T) {
mem := memory.NewCheckedAllocator(memory.NewGoAllocator())
defer mem.AssertSize(t, 0)
Expand Down