Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: [R] add back dplyr:: to left_join calls #43348

Merged
merged 1 commit into from
Jul 21, 2024

Conversation

jonkeane
Copy link
Member

Necessary for a clean check. These were inadvertently taken out in #41576 and don't actually change any code, just appeases the static checker that CRAN runs.

Copy link
Member

@nealrichardson nealrichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up. The other way around this is to call left_join.arrow_dplyr_query like L78 does, but I don't think we need to worry about the possibility that you're in this code block but don't have dplyr installed.

@jonkeane jonkeane merged commit c3ebdf5 into apache:main Jul 21, 2024
11 checks passed
@jonkeane jonkeane removed the awaiting committer review Awaiting committer review label Jul 21, 2024
jonkeane added a commit that referenced this pull request Jul 21, 2024
Necessary for a clean check. These were inadvertently taken out in #41576 and don't actually change any code, just appeases the static checker that CRAN runs.

Authored-by: Jonathan Keane <jkeane@gmail.com>
Signed-off-by: Jonathan Keane <jkeane@gmail.com>
Copy link

After merging your PR, Conbench analyzed the 0 benchmarking runs that have been run so far on merge-commit c3ebdf5.

None of the specified runs were found on the Conbench server.

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants