GH-43194: [R] R_existsVarInFrame isn't available earlier than R 4.2 #43243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@github-actions crossbow submit test-r-versions |
|
|
github-actions
bot
added
Component: R
awaiting committer review
|
Revision: 7414f23 Submitted crossbow builds: ursacomputing/crossbow @ actions-edac7fb428
|
|
@github-actions crossbow submit test-r-rstudio-r-base-4.1-opensuse155 r-binary-packages |
|
Revision: 7414f23 Submitted crossbow builds: ursacomputing/crossbow @ actions-fa92c5b35b
|
thisisnic
approved these changes
Jul 14, 2024
github-actions
bot
added
awaiting merge
|
Revision: 7414f23 Submitted crossbow builds: ursacomputing/crossbow @ actions-4dc7fa4731
|
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 0372617. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
38 tasks
jonkeane
added a commit
that referenced
this pull request
Jul 18, 2024
…43243) ### Rationale for this change `R_existsVarInFrame` doesn't exist before R 4.2, so we need to fall back to `Rf_findVarInFrame3` if it is not defined. Resolves #43194 ### What changes are included in this PR? `ifdef`s ### Are these changes tested? Yes, in our extended CI `test-r-versions`, `test-r-rstudio-r-base-4.1-opensuse155` ### Are there any user-facing changes? No * GitHub Issue: #43194 Authored-by: Jonathan Keane <jkeane@gmail.com> Signed-off-by: Jonathan Keane <jkeane@gmail.com>
jonkeane
added a commit
that referenced
this pull request
Aug 1, 2024
A follow on to #43243 `#ifdef function declaration` does not work, instead we must use the `#if (R_VERSION >= R_Version(4, 2, 0))` pattern to only include code for specific versions. Lead-authored-by: Jonathan Keane <jkeane@gmail.com> Co-authored-by: Neal Richardson <neal.p.richardson@gmail.com> Signed-off-by: Jonathan Keane <jkeane@gmail.com>
jonkeane
added a commit
that referenced
this pull request
Aug 5, 2024
A follow on to #43243 `#ifdef function declaration` does not work, instead we must use the `#if (R_VERSION >= R_Version(4, 2, 0))` pattern to only include code for specific versions. Lead-authored-by: Jonathan Keane <jkeane@gmail.com> Co-authored-by: Neal Richardson <neal.p.richardson@gmail.com> Signed-off-by: Jonathan Keane <jkeane@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
R_existsVarInFramedoesn't exist before R 4.2, so we need to fall back toRf_findVarInFrame3if it is not defined.Resolves #43194
What changes are included in this PR?
ifdefsAre these changes tested?
Yes, in our extended CI
test-r-versions,test-r-rstudio-r-base-4.1-opensuse155Are there any user-facing changes?
No
R_existsVarInFrameisn't available earlier than R 4.2 #43194