-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-43058: [C#] Revert upgrade of Xunit from 2.8.0 to 2.8.1 #43074
Conversation
|
@github-actions crossbow submit verify-rc-source-csharp-* |
Revision: 9ccaab0 Submitted crossbow builds: ursacomputing/crossbow @ actions-de71895c86 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 8909163. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
…8.1 (apache#43074)" This reverts commit 8909163.
…che#43074) ### Rationale for this change See apache#43058, this release broke compatibility with xunit.skippablefact and caused skipped tests to be treated as failures. ### What changes are included in this PR? This reverts commit ef3d467. ### Are these changes tested? Yes ### Are there any user-facing changes? No * GitHub Issue: apache#43058 Authored-by: Adam Reeve <adreeve@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Rationale for this change
See #43058, this release broke compatibility with xunit.skippablefact and caused skipped tests to be treated as failures.
What changes are included in this PR?
This reverts commit ef3d467.
Are these changes tested?
Yes
Are there any user-facing changes?
No