Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-42197: [CI][Packaging][Java] Ensure updating "python@*" formulae on macOS #42202

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

kou
Copy link
Member

@kou kou commented Jun 18, 2024

Rationale for this change

macOS GitHub Actions runners have Python not installed by Homebrew at /usr/local/.
If we install python@XXX Homebrew formula, it tries to overwrite /usr/local/bin/2to3 and so on and causes a conflict error.

NOTE: This is happen only when pre-installed Homebrew python@XXX on macOS GitHub Actions runners is outdated. (python@XXX is updated after macOS GitHub Actions runner image is created.)

What changes are included in this PR?

Ensure updating pythone@XXX with --overwrite before we use brew bundle.
brew bundle may update python@XXX automatically without --overwrite.

FYI: brew bundle --force ... will also work.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

@kou
Copy link
Member Author

kou commented Jun 18, 2024

@github-actions crossbow submit java-jars

Copy link

⚠️ GitHub issue #42197 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Jun 18, 2024
Copy link

Revision: 97b7dd3

Submitted crossbow builds: ursacomputing/crossbow @ actions-7c20026b48

Task Status
java-jars GitHub Actions

@kou
Copy link
Member Author

kou commented Jun 18, 2024

Hmm. macOS GitHub Actions runner image is updated and our job works without this. (We can't test this for now.)

https://github.com/ursacomputing/crossbow/actions/runs/9572207778/job/26391031744#step:1:9

   Version: 20240616.1
  Included Software: https://github.com/actions/runner-images/blob/macos-13/20240616.1/images/macos/macos-13-Readme.md
  Image Release: https://github.com/actions/runner-images/releases/tag/macos-13%2F20240616.1

https://github.com/ursacomputing/crossbow/actions/runs/9572207778/job/26391031744#step:5:89

Warning: python@3.12 3.12.4 is already installed and up-to-date.
To reinstall 3.12.4, run:
  brew reinstall python@3.12

Can we merge this without testing the error case...?

@assignUser
Copy link
Member

I feel like I have seen an issue about this in the runner repo...

@assignUser
Copy link
Member

assignUser commented Jun 19, 2024

actions/runner-images#9966 if they implement a fix we can remove workarounds. Let's merge this for now

@raulcd raulcd merged commit 6bcb418 into apache:main Jun 19, 2024
7 checks passed
@raulcd raulcd removed the awaiting committer review Awaiting committer review label Jun 19, 2024
@github-actions github-actions bot added the awaiting merge Awaiting merge label Jun 19, 2024
@kou kou deleted the ci-java-jars-macos branch June 19, 2024 07:56
Copy link

After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 6bcb418.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 7 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting merge Awaiting merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants