-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-42197: [CI][Packaging][Java] Ensure updating "python@*" formulae on macOS #42202
Conversation
@github-actions crossbow submit java-jars |
|
Revision: 97b7dd3 Submitted crossbow builds: ursacomputing/crossbow @ actions-7c20026b48
|
Hmm. macOS GitHub Actions runner image is updated and our job works without this. (We can't test this for now.) https://github.com/ursacomputing/crossbow/actions/runs/9572207778/job/26391031744#step:1:9
https://github.com/ursacomputing/crossbow/actions/runs/9572207778/job/26391031744#step:5:89
Can we merge this without testing the error case...? |
I feel like I have seen an issue about this in the runner repo... |
actions/runner-images#9966 if they implement a fix we can remove workarounds. Let's merge this for now |
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 6bcb418. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 7 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
macOS GitHub Actions runners have Python not installed by Homebrew at
/usr/local/
.If we install
python@XXX
Homebrew formula, it tries to overwrite/usr/local/bin/2to3
and so on and causes a conflict error.NOTE: This is happen only when pre-installed Homebrew
python@XXX
on macOS GitHub Actions runners is outdated. (python@XXX
is updated after macOS GitHub Actions runner image is created.)What changes are included in this PR?
Ensure updating
pythone@XXX
with--overwrite
before we usebrew bundle
.brew bundle
may updatepython@XXX
automatically without--overwrite
.FYI:
brew bundle --force ...
will also work.Are these changes tested?
Yes.
Are there any user-facing changes?
No.