-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-42104: [C++] Fix an OTel test failure and remove needless logs #42122
Conversation
Approved assuming CI passes (though I see some failures; since it's MATLAB etc maybe those are flakes?) |
Took a closer look and the failures seem unrelated to me. |
The MATLAB failure is #42015 and it'll be fixed by rebasing on main. |
fcd80f2
to
3870d7b
Compare
@github-actions crossbow submit -g cpp |
auto env_var = arrow::internal::GetEnvVar(kLoggingEnvVar); | ||
if (env_var.status().IsKeyError()) { | ||
GTEST_SKIP() << "Env var " << kLoggingEnvVar << " is undefined"; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If these tests need an env var to be set, can it be set 1) either in the test setup (if not too late) 2) or in ci/scripts/cpp_test.sh
? It would be better than skipping this test on many different CI configurations.
(it would probably be better if the tests could be made independent of the environment, btw, but I realize that may be difficult depending on implementation specifics)
Revision: 3870d7b Submitted crossbow builds: ursacomputing/crossbow @ actions-ee903ae6eb |
@pitrou Can we merge this? I want to fix CI failures on main. |
After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 59267e0. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 6 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
Follow-up to #39905, as some issues popped after merging.
What changes are included in this PR?
ARROW_LOGGING_BACKEND
env var not being definedAre these changes tested?
Yes
Are there any user-facing changes?
No
TestLogging.Basics
in arrow-telemetry-test #42104