Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-42104: [C++] Fix an OTel test failure and remove needless logs #42122

Merged
merged 3 commits into from
Jun 24, 2024

Conversation

benibus
Copy link
Collaborator

@benibus benibus commented Jun 12, 2024

Rationale for this change

Follow-up to #39905, as some issues popped after merging.

What changes are included in this PR?

  • Fixes tests failing due to the ARROW_LOGGING_BACKEND env var not being defined
  • Removes example log statements accidentally left in PR

Are these changes tested?

Yes

Are there any user-facing changes?

No

@lidavidm
Copy link
Member

Approved assuming CI passes (though I see some failures; since it's MATLAB etc maybe those are flakes?)

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Jun 12, 2024
@benibus
Copy link
Collaborator Author

benibus commented Jun 12, 2024

though I see some failures; since it's MATLAB etc maybe those are flakes?

Took a closer look and the failures seem unrelated to me.

@kou
Copy link
Member

kou commented Jun 12, 2024

The MATLAB failure is #42015 and it'll be fixed by rebasing on main.

@benibus benibus force-pushed the GH-42104-logging-test-failure branch from fcd80f2 to 3870d7b Compare June 12, 2024 21:04
@pitrou
Copy link
Member

pitrou commented Jun 13, 2024

@github-actions crossbow submit -g cpp

Comment on lines 84 to 87
auto env_var = arrow::internal::GetEnvVar(kLoggingEnvVar);
if (env_var.status().IsKeyError()) {
GTEST_SKIP() << "Env var " << kLoggingEnvVar << " is undefined";
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If these tests need an env var to be set, can it be set 1) either in the test setup (if not too late) 2) or in ci/scripts/cpp_test.sh? It would be better than skipping this test on many different CI configurations.

(it would probably be better if the tests could be made independent of the environment, btw, but I realize that may be difficult depending on implementation specifics)

Copy link

Revision: 3870d7b

Submitted crossbow builds: ursacomputing/crossbow @ actions-ee903ae6eb

Task Status
test-alpine-linux-cpp GitHub Actions
test-build-cpp-fuzz GitHub Actions
test-conda-cpp GitHub Actions
test-conda-cpp-valgrind GitHub Actions
test-cuda-cpp GitHub Actions
test-debian-12-cpp-amd64 GitHub Actions
test-debian-12-cpp-i386 GitHub Actions
test-fedora-39-cpp GitHub Actions
test-ubuntu-20.04-cpp GitHub Actions
test-ubuntu-20.04-cpp-bundled GitHub Actions
test-ubuntu-20.04-cpp-minimal-with-formats GitHub Actions
test-ubuntu-20.04-cpp-thread-sanitizer GitHub Actions
test-ubuntu-22.04-cpp GitHub Actions
test-ubuntu-22.04-cpp-20 GitHub Actions
test-ubuntu-22.04-cpp-emscripten GitHub Actions
test-ubuntu-22.04-cpp-no-threading GitHub Actions
test-ubuntu-24.04-cpp GitHub Actions
test-ubuntu-24.04-cpp-gcc-14 GitHub Actions

@kou
Copy link
Member

kou commented Jun 22, 2024

@pitrou Can we merge this? I want to fix CI failures on main.

@kou kou changed the title GH-42104: [C++] Fixes following OTel logging PR GH-42104: [C++] Fix an OTel test failure and remove needless logs Jun 24, 2024
@kou kou merged commit 59267e0 into apache:main Jun 24, 2024
38 of 40 checks passed
@kou kou removed the awaiting merge Awaiting merge label Jun 24, 2024
Copy link

After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 59267e0.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 6 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants