Skip to content

Conversation

@sbinet
Copy link
Contributor

@sbinet sbinet commented Apr 16, 2019

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #4155 into master will decrease coverage by 26.97%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #4155       +/-   ##
===========================================
- Coverage   87.89%   60.92%   -26.98%     
===========================================
  Files         758       67      -691     
  Lines       92163     4862    -87301     
  Branches     1251        0     -1251     
===========================================
- Hits        81006     2962    -78044     
+ Misses      11040     1791     -9249     
+ Partials      117      109        -8
Impacted Files Coverage Δ
go/arrow/ipc/file_reader.go 0% <0%> (ø) ⬆️
python/pyarrow/ipc.pxi
cpp/src/arrow/csv/chunker-test.cc
cpp/src/parquet/column_page.h
cpp/src/parquet/bloom_filter-test.cc
cpp/src/arrow/array/builder_decimal.cc
cpp/src/plasma/client.cc
cpp/src/arrow/io/test-common.h
cpp/src/arrow/util/int-util-test.cc
cpp/src/arrow/python/io.cc
... and 682 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c0930d...50f83a7. Read the comment docs.

@sbinet
Copy link
Contributor Author

sbinet commented Apr 16, 2019

PTAL @stuartcarnie @alexandreyc @nickpoorman

@alexandreyc
Copy link
Contributor

I still need to fully review ARROW-5108 before doing this one, but I will.

@sbinet
Copy link
Contributor Author

sbinet commented Apr 16, 2019

you mean #4114 ?
oops, already collected it... my bad.

Copy link
Contributor

@stuartcarnie stuartcarnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants