GH-38573: [Java][FlightRPC] Try all locations in JDBC driver #40104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: Java
awaiting committer review
lidavidm
commented
Feb 20, 2024
| .maxTraceEvents(MAX_CHANNEL_TRACE_EVENTS) | ||
| .maxInboundMessageSize(maxInboundMessageSize); | ||
| .maxInboundMessageSize(maxInboundMessageSize) | ||
| .maxInboundMetadataSize(maxInboundMessageSize); |
Member
Author
There was a problem hiding this comment.
I've noticed this is required for some implementations that try to return a relatively large error message. Without this, clients like DBeaver throw odd errors instead of giving the actual error message.
github-actions
bot
added
awaiting changes
jduo
reviewed
Feb 20, 2024
...jdbc-core/src/main/java/org/apache/arrow/driver/jdbc/client/ArrowFlightSqlClientHandler.java
Show resolved
Hide resolved
jduo
approved these changes
Feb 20, 2024
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit aa6b398. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 6 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Member
|
@github-actions crossbow submit java-jars |
|
Revision: ba56395 Submitted crossbow builds: ursacomputing/crossbow @ actions-ecf31db188
|
pribor
pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
…pache#40104) ### Rationale for this change This brings the JDBC driver up to par with other Flight SQL clients. ### What changes are included in this PR? Try multiple locations for the Flight SQL driver. ### Are these changes tested? Yes ### Are there any user-facing changes? No * Closes: apache#38573 Authored-by: David Li <li.davidm96@gmail.com> Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This brings the JDBC driver up to par with other Flight SQL clients.
What changes are included in this PR?
Try multiple locations for the Flight SQL driver.
Are these changes tested?
Yes
Are there any user-facing changes?
No