Skip to content

ARROW-4586: [Rust] Remove arrow/mod.rs as it is not needed #3659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

ARROW-4586: [Rust] Remove arrow/mod.rs as it is not needed #3659

wants to merge 1 commit into from

Conversation

@paddyhoran
Copy link
Contributor

mod.rs is not needed as lib.rs imports sub-modules directly. In fact, it's not compiled at all from what I can see...

@nevi-me
Copy link
Contributor

nevi-me commented Feb 15, 2019 •
edited
Loading

I'll add it back in the JSON reader PR, I had deleted it there

andygrove
andygrove approved these changes Feb 16, 2019
View reviewed changes
Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I'd been meaning to get to this too.

@andygrove andygrove closed this in e1bc0d4 Feb 16, 2019
@paddyhoran paddyhoran deleted the remove-mod branch February 16, 2019 18:14
@asfimport asfimport mentioned this pull request Feb 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andygrove andygrove andygrove approved these changes

@nevi-me nevi-me nevi-me approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@paddyhoran @nevi-me @andygrove