Skip to content

Conversation

@eerhardt
Copy link
Contributor

  • Update FlatBuffers code to latest version.
  • Mark all FlatBuffer types as internal.

Note: I didn't use the latest .fbs file version because it included the SparseTensor support. Using the latest .fbs change caused problems with the Tensor generation. I have a question if the latest .fbs file is correct.

/cc @chutchinson @stephentoub - FYI

Update FlatBuffers code to latest version.
Mark all FlatBuffer types as internal.
@eerhardt
Copy link
Contributor Author

@wesm @xhochy - how do I re-run the travis-ci? I don't think the failure is related to my proposed change.

@kou
Copy link
Member

kou commented Feb 14, 2019

I restarted the failed job manually.
You can re-run all jobs by force push.

Copy link
Member

@xhochy xhochy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, the build failure is unrelated.

@eerhardt Can you add a line to the README on how to update these files?

@eerhardt
Copy link
Contributor Author

Can you add a line to the README on how to update these files?

Done. Thanks for the review.

@kszucs kszucs closed this in 9600d8b Feb 18, 2019
@kszucs
Copy link
Member

kszucs commented Feb 18, 2019

Thanks @eerhardt!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants