-
Notifications
You must be signed in to change notification settings - Fork 3.9k
GH-36038: [Python] Implement __reduce__ on ExtensionType class #36170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-36038: [Python] Implement __reduce__ on ExtensionType class #36170
Conversation
jorisvandenbossche
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Do you know if we have test coverage for the array itself also being pickleable?
I don't think so. Will check and add if necessary 👍 |
|
There is a test for |
|
@jorisvandenbossche I plan to merge this unless there is some issue with changes from the last commit 7d72817. |
jorisvandenbossche
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
Conbench analyzed the 6 benchmark runs on commit There were 5 benchmark results indicating a performance regression:
The full Conbench report has more details. |
Rationale for this change
ExtensionTypesubclasses can't be pickled if__reduce__method isn't implemented separately.What changes are included in this PR?
Add
__reduce__method toExtensionTypeclass.Are these changes tested?
Yes, test is added to python/pyarrow/tests/test_extension_type.py.
Are there any user-facing changes?
No.