Skip to content

Conversation

@kou
Copy link
Member

@kou kou commented Jun 10, 2023

Rationale for this change

GLib/Ruby tests show progress log by default:

https://github.com/ursacomputing/crossbow/actions/runs/5230026234/jobs/9443353956#step:6:10172

|
/
-
\
|
/
-
\
|

It's useful on local run but meaningless on CI.

What changes are included in this PR?

Pass through GITHUB_ACTIONS environment variable because the testing frame that is used by GLib/Ruby tests suppress the progress log with GITHUB_ACTIONS=true automatically.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

@kou kou requested review from assignUser and raulcd as code owners June 10, 2023 20:44
@github-actions
Copy link

⚠️ GitHub issue #36023 has been automatically assigned in GitHub to PR creator.

@kou
Copy link
Member Author

kou commented Jun 10, 2023

@github-actions crossbow submit verify-rc-source-ruby-linux-*

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Jun 10, 2023
@github-actions
Copy link

Revision: b28ca7c

Submitted crossbow builds: ursacomputing/crossbow @ actions-43ac44d8ee

Task Status
verify-rc-source-ruby-linux-almalinux-8-amd64 Github Actions
verify-rc-source-ruby-linux-conda-latest-amd64 Github Actions
verify-rc-source-ruby-linux-ubuntu-20.04-amd64 Github Actions
verify-rc-source-ruby-linux-ubuntu-22.04-amd64 Github Actions

Copy link
Member

@assignUser assignUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@assignUser assignUser merged commit 98559fe into apache:main Jun 13, 2023
@kou kou deleted the ci-verify-rc-ruby-github-actions branch June 13, 2023 04:14
@ursabot
Copy link

ursabot commented Jun 13, 2023

Benchmark runs are scheduled for baseline = c13275e and contender = 98559fe. 98559fe is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️1.0% ⬆️0.21%] test-mac-arm
[Finished ⬇️0.33% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.39% ⬆️0.09%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 98559fe0 ec2-t3-xlarge-us-east-2
[Finished] 98559fe0 test-mac-arm
[Finished] 98559fe0 ursa-i9-9960x
[Finished] 98559fe0 ursa-thinkcentre-m75q
[Finished] c13275e1 ec2-t3-xlarge-us-east-2
[Finished] c13275e1 test-mac-arm
[Finished] c13275e1 ursa-i9-9960x
[Finished] c13275e1 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting committer review Awaiting committer review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI][Ruby][Release] Suppress meaningless progress log from verify-rc-ruby

3 participants