GH-35442: [C++][FlightRPC] Pass ServerCallContext instead of CallHeaders to ServerMiddlewareFactory::StartCall() #35454
Conversation
…llHeaders to ServerMiddlewareFactory::StartCall()
|
|
github-actions
bot
added
Component: C++
Component: FlightRPC
awaiting committer review
github-actions
bot
added
awaiting merge
|
Benchmark runs are scheduled for baseline = b43f4cd and contender = f0e1453. f0e1453 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
|
['Python', 'R'] benchmarks have high level of regressions. |
…llHeaders to ServerMiddlewareFactory::StartCall() (apache#35454) ### Rationale for this change Because it's also a RPC call like others such as `ListFlights()` and `DoGet()`. If we pass `ServerCallContext` instead of `CallHeaders`, implementers can also get other information such as client address. For example, https://github.com/apache/arrow-flight-sql-postgresql will use it by `ServerCallContext::peer()`. ### What changes are included in this PR? Passes `ServerCallContext` instead of `CallHeaders` but keeps a backward compatibility. Implementers can still use the old signature. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. But this is still backward compatible. * Closes: apache#35442 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
…llHeaders to ServerMiddlewareFactory::StartCall() (apache#35454) ### Rationale for this change Because it's also a RPC call like others such as `ListFlights()` and `DoGet()`. If we pass `ServerCallContext` instead of `CallHeaders`, implementers can also get other information such as client address. For example, https://github.com/apache/arrow-flight-sql-postgresql will use it by `ServerCallContext::peer()`. ### What changes are included in this PR? Passes `ServerCallContext` instead of `CallHeaders` but keeps a backward compatibility. Implementers can still use the old signature. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. But this is still backward compatible. * Closes: apache#35442 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
3 participants
Rationale for this change
Because it's also a RPC call like others such as
ListFlights()andDoGet().If we pass
ServerCallContextinstead ofCallHeaders, implementers can also get other information such as client address. For example, https://github.com/apache/arrow-flight-sql-postgresql will use it byServerCallContext::peer().What changes are included in this PR?
Passes
ServerCallContextinstead ofCallHeadersbut keeps a backward compatibility.Implementers can still use the old signature.
Are these changes tested?
Yes.
Are there any user-facing changes?
Yes. But this is still backward compatible.