Skip to content

GH-35375: [C++][FlightRPC] Add arrow::flight::ServerCallContext::incoming_headers() #35376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kou merged 2 commits into from
May 1, 2023
Merged

GH-35375: [C++][FlightRPC] Add arrow::flight::ServerCallContext::incoming_headers() #35376

kou merged 2 commits into from
May 1, 2023

Conversation

@kou
Copy link
Member

@kou kou commented May 1, 2023 •
edited by github-actions bot
Loading

Rationale for this change

It returns headers sent by a client.

We can get them only in arrow::flight::ServerMiddlewareCactory::StartCall() for now. But they're useful for in each RPC call.

What changes are included in this PR?

Add the method.

Are these changes tested?

Yes.

Are there any user-facing changes?

Yes.

@kou kou requested a review from lidavidm as a code owner May 1, 2023 03:38
@github-actions
Copy link

github-actions bot commented May 1, 2023

@github-actions
Copy link

github-actions bot commented May 1, 2023

⚠️ GitHub issue #35375 has been automatically assigned in GitHub to PR creator.

lidavidm
lidavidm approved these changes May 1, 2023
View reviewed changes
Copy link
Member

@lidavidm lidavidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels May 1, 2023
@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting merge Awaiting merge labels May 1, 2023
lidavidm
lidavidm approved these changes May 1, 2023
View reviewed changes
Copy link
Member

@lidavidm lidavidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting changes Awaiting changes labels May 1, 2023
@kou kou merged commit 75439f0 into apache:main May 1, 2023
@kou kou deleted the cpp-flight-server-call-context-incoming-headers branch May 1, 2023 09:40
@ursabot
Copy link

ursabot commented May 1, 2023

Benchmark runs are scheduled for baseline = 0ea1a10 and contender = 75439f0. 75439f0 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️2.1% ⬆️0.18%] test-mac-arm
[Failed ⬇️1.57% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️1.6% ⬆️0.36%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 75439f09 ec2-t3-xlarge-us-east-2
[Failed] 75439f09 test-mac-arm
[Failed] 75439f09 ursa-i9-9960x
[Finished] 75439f09 ursa-thinkcentre-m75q
[Finished] 0ea1a103 ec2-t3-xlarge-us-east-2
[Failed] 0ea1a103 test-mac-arm
[Failed] 0ea1a103 ursa-i9-9960x
[Finished] 0ea1a103 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

liujiacheng777 pushed a commit to LoongArch-Python/arrow that referenced this pull request May 11, 2023
@kou @liujiacheng777
apacheGH-35375: [C++][FlightRPC] Add `arrow::flight::ServerCallContex…
d936fb1 
…t::incoming_headers()` (apache#35376)

### Rationale for this change

It returns headers sent by a client.

We can get them only in `arrow::flight::ServerMiddlewareCactory::StartCall()` for now. But they're useful for in each RPC call.

### What changes are included in this PR?

Add the method.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* Closes: apache#35375

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this pull request May 15, 2023
@kou @ArgusLi
apacheGH-35375: [C++][FlightRPC] Add `arrow::flight::ServerCallContex…
d8562e7 
…t::incoming_headers()` (apache#35376)

### Rationale for this change

It returns headers sent by a client.

We can get them only in `arrow::flight::ServerMiddlewareCactory::StartCall()` for now. But they're useful for in each RPC call.

### What changes are included in this PR?

Add the method.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* Closes: apache#35375

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lidavidm lidavidm lidavidm approved these changes

Assignees

No one assigned

Labels

awaiting merge Awaiting merge Component: C++ Component: FlightRPC

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[C++][FlightRPC] Add arrow::flight::ServerCallContext::incoming_headers()

3 participants

@kou @ursabot @lidavidm