Skip to content

Conversation

@sunchao
Copy link
Member

@sunchao sunchao commented Dec 31, 2018

This moves the parquet related code into a separate sub-crate that
depends on arrow.

sunchao and others added 3 commits December 31, 2018 15:46
@kou
Copy link
Member

kou commented Jan 1, 2019

I've added a commit to update version on release process.

Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sunchao
Copy link
Member Author

sunchao commented Jan 2, 2019

Thanks @kou ! Regarding the release, I'm wondering whether every crate (e.g., arrow, parquet) has to use the same version number, and be released at the same time. Could we do separate releases for the crates with different version numbers?

@kou
Copy link
Member

kou commented Jan 2, 2019

whether every crate (e.g., arrow, parquet) has to use the same version number

We use different versions in C++. Parquet C++ uses https://github.com/apache/arrow/blob/master/cpp/src/parquet/.parquetcppversion and other C++ modules (Arrow, Plasma and Gandiva) use the same versions.

We use the same versions in C and Ruby.

I think that we can use the different versions in Rust too but we may need to discuss it on mailing list.

Could we do separate releases for the crates with different version numbers?

I'm not sure separate release is good for us.

We use different versions in C++ but we don't use separate release for C++.

We use separate release for JavaScript.

Separate release will be possible but we may need to discuss it on mailing list.
Our release cycle will be shorter in 2019. So we may not need separate release.

@kou
Copy link
Member

kou commented Jan 2, 2019

BTW, we use subdirectories both for Arrow and Parquet in C++, C and Ruby:

We may like the structure in Rust. (I think that this is out of scope of this pull request.)

@sunchao
Copy link
Member Author

sunchao commented Jan 2, 2019

Thanks @kou ! good suggestion on the sub-directory - will look into that after this PR. I'll also send an email to the dev mailing list.

@kou
Copy link
Member

kou commented Jan 2, 2019

Thanks!

@kszucs
Copy link
Member

kszucs commented Jan 3, 2019

Agree with @kou on the dub-directories.

@kszucs kszucs closed this in 1291274 Jan 3, 2019
@kszucs
Copy link
Member

kszucs commented Jan 3, 2019

Thanks @sunchao for the PR and thanks @andygrove @paddyhoran for the reviews!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants