-
Notifications
You must be signed in to change notification settings - Fork 3.9k
ARROW-4137: [Rust] Move parquet code into a separate crate #3291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This moves the parquet related code into a separate sub-crate that depends on arrow.
|
I've added a commit to update version on release process. |
andygrove
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Thanks @kou ! Regarding the release, I'm wondering whether every crate (e.g., arrow, parquet) has to use the same version number, and be released at the same time. Could we do separate releases for the crates with different version numbers? |
We use different versions in C++. Parquet C++ uses https://github.com/apache/arrow/blob/master/cpp/src/parquet/.parquetcppversion and other C++ modules (Arrow, Plasma and Gandiva) use the same versions. We use the same versions in C and Ruby. I think that we can use the different versions in Rust too but we may need to discuss it on mailing list.
I'm not sure separate release is good for us. We use different versions in C++ but we don't use separate release for C++. We use separate release for JavaScript. Separate release will be possible but we may need to discuss it on mailing list. |
|
BTW, we use subdirectories both for Arrow and Parquet in C++, C and Ruby:
We may like the structure in Rust. (I think that this is out of scope of this pull request.) |
|
Thanks @kou ! good suggestion on the sub-directory - will look into that after this PR. I'll also send an email to the dev mailing list. |
|
Thanks! |
|
Agree with @kou on the dub-directories. |
|
Thanks @sunchao for the PR and thanks @andygrove @paddyhoran for the reviews! |
This moves the parquet related code into a separate sub-crate that
depends on arrow.