ARROW-3920: [plasma] Fix reference counting in custom tensorflow plasma operator. #3061
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertnishihara
changed the title
|
Thoughts:
|
|
Thanks @concretevitamin!
|
pcmoritz
force-pushed
the
extrareleaseinplasmaop
branch
from
a4ff374 to
4836342
Compare
robertnishihara
commented
Dec 1, 2018
| ARROW_CHECK_OK(client_.Release(object_id)); | ||
| auto orig_stream = context->op_device_context()->stream(); | ||
| auto stream_executor = orig_stream->parent(); | ||
| CHECK(stream_executor->HostMemoryUnregister(static_cast<void*>(data))); |
There was a problem hiding this comment.
We probably only want this to happen in the GPU case, right?
There was a problem hiding this comment.
Same with the other op.
There was a problem hiding this comment.
Yeah, I updated it (it actually doesn't compile for cpu only tensorflow).
Codecov Report
@@ Coverage Diff @@
## master #3061 +/- ##
==========================================
- Coverage 87.07% 87.07% -0.01%
==========================================
Files 489 489
Lines 69160 69161 +1
==========================================
- Hits 60222 60221 -1
- Misses 8837 8839 +2
Partials 101 101
Continue to review full report at Codecov.
|
robertnishihara
pushed a commit
to ray-project/ray
that referenced
this pull request
Dec 2, 2018
This includes a fix so the TensorFlow op releases memory properly (apache/arrow#3061) and the possibility to store arrow data structures in plasma (apache/arrow#2832). #3404
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue here where
Releasewas never being called in the plasma TF operator.Note that I also changed the release delay in the plasma operator to 0.