-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-3439: [R] R language bindings for Feather format #2947
Closed
Closed
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
56ff849
using struct input_parameter<const std::shared_ptr<T>& instead of the…
romainfrancois df5fdba
R6 class support for arrow::ipc::Message backed by a unique_ptr
romainfrancois 8a695b8
lint
romainfrancois 7751a1c
s/construct/shared_ptr/, add unique_ptr R function. support for uniqu…
romainfrancois 432588c
Message and MessageReader
romainfrancois 61fec71
👶 support for feather::TableWriter
romainfrancois a144cfd
exposing feather::TableReader
romainfrancois 8825b3e
lint 🤷
♀️
romainfrancois 2a62b72
using construct and STOP_IF_NOT_OK (rebase)
romainfrancois 43cab06
Fixes for write_feather
romainfrancois 14b169d
until we figure out how to probably do double dispatch and 🤐 check
romainfrancois d5f886d
Add mmap argument to table_reader so that character method uses mmap_…
romainfrancois da9df5d
+ feather prefix -> feather_table_writer and feather_table_reader
romainfrancois fd1b7d5
additional test using mmap_open() and file_open() directly
romainfrancois 8d708e2
added `mmap` argument to all methods of feather_table_reader
romainfrancois File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
+ feather prefix -> feather_table_writer and feather_table_reader
- Loading branch information
commit da9df5d69dfe5c082edaa87096718dcc3e65c9c5
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It occurs to me that the semantics of this function are different from
feather::read_feather
(it returns anarrow::Table
instead ofdata.frame
), if we careThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO it would be a nice incentive for people to abandon the
feather
package in favor ofarrow
if we could sayarrow::read_feather()
/arrow::write_feathe()r
are drop-in replacements.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One of the goals of
arrow
is to make Array structures palpable in R, which feather didn't do. But yeah I guess we need both, i.e.arrow::Table
, not sure how to call this one.read_feather
if this need to look likefeather::read_feather
that returns a tibble by calling as_tibble on the result of the first one.Right now, it makes sense to go straight to tibble, but soon enough this (or other) packages will have more tooling to manipulate and compute directly on arrow memory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could add an
as_tibble = TRUE
argument toread_feather
so this can be toggled on and off