Skip to content

ARROW-3659: [CI] Fix Travis matrix entry 2 documentation to use gcc #2878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

ARROW-3659: [CI] Fix Travis matrix entry 2 documentation to use gcc #2878

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
60961df
use clang in build matrix 2
pcmoritz Oct 31, 2018
a42c141
install clang tools
pcmoritz Oct 31, 2018
d41c66c
update
pcmoritz Oct 31, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ matrix:
- $TRAVIS_BUILD_DIR/ci/travis_install_clang_tools.sh
script:
- $TRAVIS_BUILD_DIR/ci/travis_lint.sh
# C++ & Python w/ clang 6.0
# C++ & Python w/ gcc 4.9
- compiler: gcc
language: cpp
os: linux
Expand All @@ -80,8 +80,7 @@ matrix:
- ARROW_TRAVIS_JAVA_BUILD_ONLY=1
# ARROW-2999 Benchmarks are disabled in Travis CI for the time being
# - ARROW_TRAVIS_PYTHON_BENCHMARKS=1
- CC="clang-6.0"
- CXX="clang++-6.0"
- MATRIX_EVAL="CC=gcc-4.9 && CXX=g++-4.9"
Copy link
Member

@pitrou pitrou Oct 31, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why MATRIX_EVAL?

Copy link
Contributor Author

@pcmoritz pcmoritz Oct 31, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because CC and CXX get exported before Travis re-exports them according to the build matrix (see the JIRA issue printout).

Copy link
Contributor Author

@pcmoritz pcmoritz Oct 31, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(the other build matrix entries do it the same way)

Copy link
Member

@pitrou pitrou Oct 31, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh, I see, thanks.

Copy link
Member

@kou kou Nov 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: We can find the MATRIX_EVAL technique in Travis CI document: https://docs.travis-ci.com/user/languages/c/#gcc-on-linux

before_script:
# (ARROW_CI_CPP_AFFECTED implies ARROW_CI_PYTHON_AFFECTED)
- if [ $ARROW_CI_PYTHON_AFFECTED != "1" ]; then exit; fi
Expand Down