ARROW-3327: [Python] Use local Arrow checkout instead of separate clone#2642
ARROW-3327: [Python] Use local Arrow checkout instead of separate clone#2642xhochy wants to merge 2 commits intoapache:masterfrom
Conversation
xhochy
changed the title
ci/travis_script_manylinux.sh
Outdated
There was a problem hiding this comment.
Does this mean build products will spill in the local checkout?
There was a problem hiding this comment.
How about ADDing arrow to the docker image instead of mounting?
There was a problem hiding this comment.
We don't run a docker build step anymore here and from my experience adding takes quite some time (at least on OSX where the files need to be sent to the docker daemon).
There was a problem hiding this comment.
Ok, I'll try to add the manylinux image to #2572.
Another question: could We rely on cmake's 3rdparty toolchain instead of building the dependencies in additional scripts?
There was a problem hiding this comment.
We're building them separately as we do some tricks like the boost namespacing but it is also a case of caching. The docker image is pre-built and will only be pulled into the Travis so that the thirdparties are not rebuild every CI run.
There was a problem hiding this comment.
Perhaps We could define a target to build the 3rdparty deps and cache them similarly. Thanks for the clarification!
|
LGTM. Any more to be done here or can I merge this? |
|
rebased |
|
OSX build failed to due conda timeouts but they are affected by the changes here. |
4 participants
No description provided.