Skip to content

Conversation

@pitrou
Copy link
Member

@pitrou pitrou commented Jul 19, 2018

Also:

  • add a ChunkedArray.equals method;
  • add RecordBatch.columns and Table.columns properties;
  • fix a bug where ChunkedArray::Equals would return true for 0-chunk arrays with different types.

…ordBatch, Table

Also add a ChunkedArray.equals method;
add RecordBatch.columns and Table.columns properties;
and fix a bug where ChunkedArray::Equals would return true for 0-chunk arrays with different types.
@pitrou pitrou force-pushed the ARROW-1715-pickle-tables branch from 3385258 to 803d274 Compare July 19, 2018 16:23
@codecov-io
Copy link

Codecov Report

Merging #2292 into master will increase coverage by 2.43%.
The diff coverage is 89.79%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2292      +/-   ##
==========================================
+ Coverage   84.25%   86.69%   +2.43%     
==========================================
  Files         290      234      -56     
  Lines       44305    41658    -2647     
==========================================
- Hits        37330    36114    -1216     
+ Misses       6944     5544    -1400     
+ Partials       31        0      -31
Impacted Files Coverage Δ
python/pyarrow/tests/test_table.py 100% <100%> (ø) ⬆️
cpp/src/arrow/table.cc 94.1% <100%> (+0.03%) ⬆️
python/pyarrow/table.pxi 70.03% <64.28%> (+1.1%) ⬆️
go/arrow/array/bufferbuilder_numeric.gen.go
go/arrow/memory/buffer.go
go/arrow/datatype_numeric.gen.go
go/arrow/array/builder.go
go/arrow/internal/cpu/cpu_x86.go
go/arrow/math/float64_amd64.go
go/arrow/array/boolean.go
... and 51 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8cd36a...803d274. Read the comment docs.

Copy link
Member

@xhochy xhochy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants