Skip to content

Conversation

@kou
Copy link
Member

@kou kou commented Jun 19, 2018

It's introduced at 408aa5a by me.
Sorry.

It's introduced at 408aa5a by me.
Sorry.
@codecov-io
Copy link

Codecov Report

Merging #2146 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2146      +/-   ##
==========================================
- Coverage   86.42%   86.39%   -0.03%     
==========================================
  Files         242      230      -12     
  Lines       41536    40644     -892     
==========================================
- Hits        35896    35116     -780     
+ Misses       5640     5528     -112
Impacted Files Coverage Δ
cpp/src/arrow/util/thread-pool-test.cc 98.91% <0%> (-0.55%) ⬇️
rust/src/builder.rs
rust/src/list.rs
rust/src/error.rs
rust/src/datatypes.rs
rust/src/buffer.rs
rust/src/lib.rs
rust/src/memory.rs
rust/src/record_batch.rs
rust/src/bitmap.rs
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 392fd02...725d783. Read the comment docs.

Copy link
Member

@xhochy xhochy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM

@xhochy xhochy closed this in a82a027 Jun 19, 2018
@kou kou deleted the cpp-fix-orc-and-protobuf-link-error branch June 19, 2018 08:39
@wesm
Copy link
Member

wesm commented Jun 21, 2018

Thank you for fixing this! I actually ran into this linker error myself when working on the TensorFlow symbol clash issue going on in that other patch. The good news is that revamping the symbols.map in that patch may resolve the problem (making it similar to the symbols.map in PyTorch). I will look in the next 5-7 days if no one beats me to it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants