ARROW-902: [C++] Script for downloading all thirdparty build dependencies and configuration for offline builds #2141
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2141 +/- ##
=======================================
Coverage 86.39% 86.39%
=======================================
Files 230 230
Lines 40701 40701
=======================================
Hits 35162 35162
Misses 5539 5539Continue to review full report at Codecov.
|
There was a problem hiding this comment.
A nice improvement for this script would be to only download files that were not yet downloaded. Either by checking for their existence or by using wget -c
There was a problem hiding this comment.
Is there a way we can avoid duplicating version numbers and download URLs between this and the CMake files?
There was a problem hiding this comment.
I don't care for the idea of maintaining the version numbers in two places either. I'm not sure how to get data from a file in to CMake. I have done a bit of Google searching and I can't really find anything conclusive. CMake does have rudimentary string / regular expression parsing, that's probably the only way. I will take a crack at it and put a file like thirdparty/versions.txt
Add additional needed dependencies for offline build
|
OK, I think I've addressed all the comments so far. I will improve the documentation / README and then this should be good to go |
wesm
changed the title
|
This should be ready to go once I get the build passing |
|
+1 |
4 participants
This patch provides a script for downloading all the third party dependencies to a particular location, and new environment variables that can be used to direct the build system to use local files for ExternalProject builds instead of accessing the internet.