ARROW-2395: [Python] Fix flake8 warnings outside of pyarrow/ directory. Check in CI #2137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xhochy
requested changes
Jun 14, 2018
python/benchmarks/common.py
Outdated
There was a problem hiding this comment.
flake8 fails on line 41 as it's Python3 only. We should either only execute it for Python 3 or make it Python2 compatible.
|
+1, will merge on passing build |
Codecov Report
@@ Coverage Diff @@
## master #2137 +/- ##
==========================================
- Coverage 86.42% 86.41% -0.01%
==========================================
Files 242 242
Lines 41536 41536
==========================================
- Hits 35896 35894 -2
- Misses 5640 5642 +2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.