Skip to content

Conversation

@andygrove
Copy link
Member

No description provided.

@andygrove andygrove changed the title Update code formatting with latest Rust nightly ** DO NOT MERGE ** Update code formatting with latest Rust nightly Jun 9, 2018
@andygrove andygrove changed the title ** DO NOT MERGE ** Update code formatting with latest Rust nightly ** DO NOT MERGE ** Update code formatting with latest Rust stable Jun 9, 2018
@andygrove andygrove changed the title ** DO NOT MERGE ** Update code formatting with latest Rust stable ARROW-2691: [Rust] Update code formatting with latest Rust stable Jun 9, 2018
@codecov-io
Copy link

Codecov Report

Merging #2126 into master will increase coverage by 0.95%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2126      +/-   ##
==========================================
+ Coverage   86.37%   87.33%   +0.95%     
==========================================
  Files         230       12     -218     
  Lines       40589      892   -39697     
==========================================
- Hits        35059      779   -34280     
+ Misses       5530      113    -5417
Impacted Files Coverage Δ
rust/src/array.rs 84.95% <ø> (ø)
cpp/src/arrow/ipc/writer.h
cpp/src/arrow/array.h
cpp/src/arrow/python/util/datetime.h
cpp/src/arrow/util/cpu-info.cc
cpp/src/arrow/ipc/message.h
cpp/src/arrow/io/io-buffered-test.cc
python/pyarrow/tests/test_deprecations.py
cpp/src/plasma/plasma.cc
cpp/src/arrow/python/numpy-internal.h
... and 233 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e4f8dd...a32d9c6. Read the comment docs.

Copy link
Member

@wesm wesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, thanks Andy. It seems like you might need to git reset --hard upstream/master on your master branch to get rid of all those merge commits

Copy link
Member

@xhochy xhochy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM

Thanks. In the longterm, should we somehow pin the version of rustfmt as we do with clang-format?

@xhochy xhochy closed this in 6df28d3 Jun 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants