ARROW-2682: [CI] Notify in Slack about broken builds #2121
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this notify on cancelled builds (which we have a lot of in Travis CI) or only builds that reach completion and fail? |
|
Not 100% sure but this should notify only on builds that are colored red in the UI. No notification for the grey (cancelled) builds. It will also only notify by default on master builds in our case. |
wesm
approved these changes
Jun 8, 2018
|
Seems like we don't need this, already getting notifications.
|
|
That notification is coming from this PR, so I guess that means the patch is working =) I'll merge it now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.