Skip to content

Conversation

@xhochy
Copy link
Member

@xhochy xhochy commented Jun 8, 2018

No description provided.

Copy link
Member

@wesm wesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, rerunning the failed build as it looks transient.

We don't indicate what values of compression are supported in the Parquet docstrings https://github.com/apache/arrow/blob/master/python/pyarrow/parquet.py#L252. We should either fix that here or in a follow-up patch, as you prefer

@codecov-io
Copy link

Codecov Report

Merging #2120 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2120      +/-   ##
==========================================
+ Coverage   86.41%   86.42%   +<.01%     
==========================================
  Files         242      242              
  Lines       41534    41536       +2     
==========================================
+ Hits        35893    35896       +3     
+ Misses       5641     5640       -1
Impacted Files Coverage Δ
python/pyarrow/parquet.py 88.95% <ø> (ø) ⬆️
python/pyarrow/tests/test_parquet.py 95.54% <100%> (ø) ⬆️
python/pyarrow/_parquet.pyx 69.12% <100%> (+0.12%) ⬆️
cpp/src/arrow/util/thread-pool-test.cc 99.45% <0%> (+0.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b00b8a...585a4bf. Read the comment docs.

@xhochy xhochy closed this in d4755e4 Jun 14, 2018
@xhochy xhochy deleted the ARROW-2677 branch June 14, 2018 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants