-
Couldn't load subscription status.
- Fork 3.9k
ARROW-2675: Fix build error with clang-10 (Apple Clang / LLVM) #2106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2106 +/- ##
=======================================
Coverage 86.37% 86.37%
=======================================
Files 230 230
Lines 40458 40458
=======================================
Hits 34946 34946
Misses 5512 5512Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, looks good. Can you create an issue over at to track this show it shows up in the changelog? https://issues.apache.org/jira/projects/ARROW
|
@xhochy already created the issue. https://issues.apache.org/jira/browse/ARROW-2675 |
|
Thanks! |
|
You mean XCode 10 instead of clang-10, right? Can you update the PR title and code comments to indicate this? |
|
@wesm I really mean clang-10. Sorry not to mention the version of XCode, it's XCode 9.4 and I'll update it. The build error with clang-10 is shown as below. |
|
OK, the LLVM project uses different version numbers to talk about Clang. The current stable version of LLVM is 6, and so Linux distributions use |
|
@wesm OK, I have changed it. |
|
@xhochy This PR has fixed the build bug and tested successfully, I think you can merge it now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM
Thanks for fixing it and taking care for the ticket naming.

As mac os X has been updated to the version 10.13.5, XCode has been updated to XCode 9.4 and Command Line Tools have been updated to the version 10.0, the clang version has also been updated to clang-10 (Apple Clang / LLVM) correspondingly. However, Arrow can only be built under clang-9, as shown in the file
arrow/cpp/cmake_modules/CompilerInfo.cmake
Line 77 in b1d1633
So, it's time to update Arrow to support clang-10.