Skip to content

Conversation

@songqing
Copy link
Contributor

@songqing songqing commented Jun 5, 2018

As mac os X has been updated to the version 10.13.5, XCode has been updated to XCode 9.4 and Command Line Tools have been updated to the version 10.0, the clang version has also been updated to clang-10 (Apple Clang / LLVM) correspondingly. However, Arrow can only be built under clang-9, as shown in the file

elseif("${COMPILER_VERSION_FULL}" MATCHES ".*clang-9")

So, it's time to update Arrow to support clang-10.

@codecov-io
Copy link

Codecov Report

Merging #2106 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2106   +/-   ##
=======================================
  Coverage   86.37%   86.37%           
=======================================
  Files         230      230           
  Lines       40458    40458           
=======================================
  Hits        34946    34946           
  Misses       5512     5512

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1d1633...980b41a. Read the comment docs.

Copy link
Member

@xhochy xhochy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, looks good. Can you create an issue over at to track this show it shows up in the changelog? https://issues.apache.org/jira/projects/ARROW

@songqing
Copy link
Contributor Author

songqing commented Jun 5, 2018

@xhochy already created the issue. https://issues.apache.org/jira/browse/ARROW-2675

@xhochy xhochy changed the title Support clang-10 ARROW-2675: Support clang-10 Jun 5, 2018
@xhochy
Copy link
Member

xhochy commented Jun 5, 2018

Thanks!

@wesm
Copy link
Member

wesm commented Jun 5, 2018

You mean XCode 10 instead of clang-10, right? Can you update the PR title and code comments to indicate this?

@songqing
Copy link
Contributor Author

songqing commented Jun 6, 2018

@wesm I really mean clang-10. Sorry not to mention the version of XCode, it's XCode 9.4 and I'll update it. The build error with clang-10 is shown as below.
build_error_with_clang-10

@wesm
Copy link
Member

wesm commented Jun 6, 2018

OK, the LLVM project uses different version numbers to talk about Clang. The current stable version of LLVM is 6, and so Linux distributions use clang-6.0 as the name of the Clang package. I guess we need to distinguish by saying "Apple Clang / LLVM" to avoid confusion

@songqing songqing changed the title ARROW-2675: Support clang-10 ARROW-2675: Support clang-10 (Apple Clang / LLVM) Jun 6, 2018
@songqing
Copy link
Contributor Author

songqing commented Jun 6, 2018

@wesm OK, I have changed it.

@songqing songqing changed the title ARROW-2675: Support clang-10 (Apple Clang / LLVM) ARROW-2675: Fix build error with clang-10 (Apple Clang / LLVM) Jun 6, 2018
@songqing
Copy link
Contributor Author

songqing commented Jun 6, 2018

@xhochy This PR has fixed the build bug and tested successfully, I think you can merge it now.

Copy link
Member

@xhochy xhochy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM

Thanks for fixing it and taking care for the ticket naming.

@xhochy xhochy closed this in b165e46 Jun 7, 2018
@songqing songqing deleted the support_clang-10 branch June 7, 2018 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants