Skip to content

Conversation

@kou
Copy link
Member

@kou kou commented May 25, 2018

They are for packaging gems. The Apache Arrow Ruby gems only include Apache Arrow Ruby related codes. So top-level LICENSE.txt and NOTICE.txt aren't suitable for it.

@codecov-io
Copy link

Codecov Report

Merging #2083 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2083      +/-   ##
==========================================
- Coverage   86.35%   86.33%   -0.03%     
==========================================
  Files         242      230      -12     
  Lines       41184    40292     -892     
==========================================
- Hits        35566    34786     -780     
+ Misses       5618     5506     -112
Impacted Files Coverage Δ
cpp/src/plasma/store.cc 88.76% <0%> (-0.46%) ⬇️
rust/src/list.rs
rust/src/lib.rs
rust/src/memory_pool.rs
rust/src/builder.rs
rust/src/array.rs
rust/src/datatypes.rs
rust/src/buffer.rs
rust/src/error.rs
rust/src/list_builder.rs
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01202cc...e3aafa5. Read the comment docs.

Copy link
Member

@wesm wesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wesm wesm closed this in 5b4728b Jun 8, 2018
@kou kou deleted the ruby-update-license branch June 11, 2018 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants