Skip to content

ARROW-2626: [Python] Add column name to exception message when writing pandas df fails #2075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

ARROW-2626: [Python] Add column name to exception message when writing pandas df fails #2075

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc1a2b5
Add column name to exception message when writing pandas df fails
louispotok May 22, 2018
cf23778
pylint fixup
louispotok May 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion python/pyarrow/pandas_compat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,7 +365,11 @@ def dataframe_to_arrays(df, schema, preserve_index, nthreads=1, columns=None):
nthreads = 1

def convert_column(col, ty):
return pa.array(col, from_pandas=True, type=ty)
try:
return pa.array(col, from_pandas=True, type=ty)
except (pa.ArrowInvalid, pa.ArrowTypeError) as e:
e.args += ("Conversion failed for column %s" % col.name,)
raise e

if nthreads == 1:
arrays = [convert_column(c, t)
Expand Down
5 changes: 5 additions & 0 deletions python/pyarrow/tests/test_convert_pandas.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1879,6 +1879,11 @@ def test_mixed_types_fails(self):
with pytest.raises(pa.ArrowTypeError):
pa.Table.from_pandas(data)

data = pd.DataFrame({'a': ['a', 1, 2.0]})
expected_msg = 'Conversion failed for column a'
with pytest.raises(pa.ArrowTypeError, match=expected_msg):
pa.Table.from_pandas(data)

def test_strided_data_import(self):
cases = []

Expand Down