-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-312: Read and write Arrow IPC file format from Python #164
Conversation
Change-Id: I47af06be9407c0b7eb39e0fb8cd37970e8eeeb67
…ext, to allow zero-copy writing of NumPy arrays Change-Id: I4747841f805e08f943e626ec3c77ac4b4fb5a0f7
Change-Id: I84cdb9a07f3853f06436c53b65fa082e3b843ed2
Change-Id: I4c56812272d083722ebf5f9d89de25ad9cfade15
…wrapped buffer. Resize buffer in BufferOutputStream on close Change-Id: I94d2689172554a55259370df99a3147e9047d421
@@ -37,8 +37,7 @@ import pyarrow.schema as schema | |||
|
|||
|
|||
def total_allocated_bytes(): | |||
cdef MemoryPool* pool = pyarrow.GetMemoryPool() | |||
return pool.bytes_allocated() | |||
cdef MemoryPool* pool = pyarrow.get_memory_pool() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Accidential deletion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, fixed
Change-Id: I211b4137081df34206eb2673a61ca6179fd0e4e9
Change-Id: I74649137694189f7d4495421aad0e45d755aa349
Locally CMake reports the following warning, this might be related to the OSX build failure in Travis:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the OSX failure: LGTM
Got it, that makes sense. Let me try to fix |
Change-Id: Ieabfb81fa335e3c18c3a93e64c5e0f2a9ee66012
There's a lot of duplicated boilerplate for configuring shared libs -- we should create some cmake functions to make this easier / cleaner -- see ARROW-330 |
+1 |
This also adds some IO scaffolding for interacting with `arrow::Buffer` objects from Python and assorted additions to help with testing. Author: Wes McKinney <wes.mckinney@twosigma.com> Closes #164 from wesm/ARROW-312 and squashes the following commits: 7df3e5f [Wes McKinney] Set BUILD_WITH_INSTALL_RPATH on arrow_ipc be8cee0 [Wes McKinney] Link Cython modules to libarrow* libraries 5716601 [Wes McKinney] Fix accidental deletion 77fb03b [Wes McKinney] Add / test Buffer wrapper. Test that we can write an arrow file to a wrapped buffer. Resize buffer in BufferOutputStream on close 316537d [Wes McKinney] Get ready to wrap Arrow buffers in a Python object 4822d32 [Wes McKinney] Implement RecordBatch::Equals, compare in Python ipc file writes a931e49 [Wes McKinney] Permit buffers (write padding) in a non-multiple of 64 in an IPC context, to allow zero-copy writing of NumPy arrays 2c49cd4 [Wes McKinney] Some debugging ca1562b [Wes McKinney] Draft implementations of Arrow file read/write from Python
This also adds some IO scaffolding for interacting with
arrow::Buffer
objects from Python and assorted additions to help with testing.