ARROW-1976: [Python] Handling unicode pandas columns on parquet.read_table #1553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
python/pyarrow/pandas_compat.py
Outdated
There was a problem hiding this comment.
Is this call to _column_name_to_strings necessary? I would think that was already done for field_name when you end up here
|
Any chance anyone has time to look at getting our CI rehabilitated so we can get a passing CI build? #1548 still has some Windows issues |
|
@wesm Looking now. |
Removing additional instances of using frombytes with str. Removing additional instances of using frombytes with str.
This reverts commit 292ac90.
Change-Id: I28c35f1c32e586a08dd8753dd7de748fa2d3407e
|
Appveyor build is running here: https://ci.appveyor.com/project/cpcloud/arrow/build/1.0.516. Will merge once that is looking good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.