ARROW-1706: [Python] Coerce array inputs to StructArray.from_arrays. Flip order of arguments #1512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpcloud
requested changes
Feb 1, 2018
python/pyarrow/array.pxi
Outdated
There was a problem hiding this comment.
If names is None this will fail. What's the desired behavior in the case that names is None?
…-pyarrow data to Array
Change-Id: Ica73595ccddbfbecfbdafb2558157778a08e7240
Change-Id: Ia329eb00148f6d2cf4cd7a69fd32bb43f9d5824f
Change-Id: I628dc819139f609e91bf2c3bc47f0886e43ab9b7
|
+1. All builds passing except the Python hang (seems ARROW-2062 wasn't enough to fix) and the Brotli toolchain issue on Appveyor: see build https://ci.appveyor.com/project/wesm/arrow/build/1.0.1662 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I flipped the argument order to be more consistent with the same methods in RecordBatch, Table. The StructArray method doesn't seem to be widely used so I'm not sure there's the need to go through a deprecation cycle