Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-18394: [Python][CI] Fix nightly job using pandas dev (temporarily skip tests) #15048

Merged
merged 9 commits into from
Dec 22, 2022

Conversation

jorisvandenbossche
Copy link
Member

No description provided.

@github-actions
Copy link

@github-actions
Copy link

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@jorisvandenbossche
Copy link
Member Author

@github-actions crossbow submit test-conda-python-3.8-pandas-nightly test-conda-python-3.9-pandas-upstream_devel

@github-actions
Copy link

Revision: aa26ee5

Submitted crossbow builds: ursacomputing/crossbow @ actions-3722540e72

Task Status
test-conda-python-3.8-pandas-nightly Github Actions
test-conda-python-3.9-pandas-upstream_devel Github Actions

@jorisvandenbossche
Copy link
Member Author

@github-actions crossbow submit test-conda-python-3.8-pandas-nightly test-conda-python-3.9-pandas-upstream_devel

@github-actions
Copy link

Revision: 65bfd46

Submitted crossbow builds: ursacomputing/crossbow @ actions-008f575c92

Task Status
test-conda-python-3.8-pandas-nightly Github Actions
test-conda-python-3.9-pandas-upstream_devel Github Actions

@jorisvandenbossche
Copy link
Member Author

@github-actions crossbow submit test-conda-python-3.8-pandas-nightly test-conda-python-3.9-pandas-upstream_devel

@github-actions
Copy link

Revision: 5f8da4a

Submitted crossbow builds: ursacomputing/crossbow @ actions-840298ad59

Task Status
test-conda-python-3.8-pandas-nightly Github Actions
test-conda-python-3.9-pandas-upstream_devel Github Actions

Copy link
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reviewed the skips and the opened issues on pandas and all that LGTM. I added a couple comments, one of them (the timestamps one) I am not sure I understand why is required.

"2008-12-28",
"2008-12-29",
"2012-01-01 01:02:03"])
"2010-01-04T07:35:35.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just curious why are those being updated? are formats like "2008-12-28" not supported anymore?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That string itself, yes, but not the mixture of different formats in a single list (but I am planning to raise an issue about this, because it seems too pedantic, as all those strings are ISO strings)

@@ -36,7 +36,7 @@ else
fi

if [ "${pandas}" = "upstream_devel" ]; then
pip install git+https://github.com/pandas-dev/pandas.git --no-build-isolation
pip install git+https://github.com/pandas-dev/pandas.git
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why we did use --no-build-isolation in the first place. LGTM

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think just to be more efficient (all dependencies like numpy and cython were already installed in the env (to build pyarrow), so no need to install those in an isolation build environment). But now pandas started to depend on versioneer as build-time dependency (instead of vendoring it), so this is the cleanest solution (otherwise we would have to install versioneer first)

@ursabot
Copy link

ursabot commented Dec 23, 2022

Benchmark runs are scheduled for baseline = 54c487b and contender = 1e15f07. 1e15f07 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed] test-mac-arm
[Finished ⬇️0.51% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.48% ⬆️0.1%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 1e15f079 ec2-t3-xlarge-us-east-2
[Failed] 1e15f079 test-mac-arm
[Finished] 1e15f079 ursa-i9-9960x
[Finished] 1e15f079 ursa-thinkcentre-m75q
[Finished] 54c487bf ec2-t3-xlarge-us-east-2
[Failed] 54c487bf test-mac-arm
[Finished] 54c487bf ursa-i9-9960x
[Finished] 54c487bf ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link

ursabot commented Dec 23, 2022

['Python', 'R'] benchmarks have high level of regressions.
ursa-i9-9960x

EpsilonPrime pushed a commit to EpsilonPrime/arrow that referenced this pull request Jan 5, 2023
…ly skip tests) (apache#15048)

Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants