-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-18394: [Python][CI] Fix nightly job using pandas dev (temporarily skip tests) #15048
ARROW-18394: [Python][CI] Fix nightly job using pandas dev (temporarily skip tests) #15048
Conversation
|
@github-actions crossbow submit test-conda-python-3.8-pandas-nightly test-conda-python-3.9-pandas-upstream_devel |
Revision: aa26ee5 Submitted crossbow builds: ursacomputing/crossbow @ actions-3722540e72
|
@github-actions crossbow submit test-conda-python-3.8-pandas-nightly test-conda-python-3.9-pandas-upstream_devel |
Revision: 65bfd46 Submitted crossbow builds: ursacomputing/crossbow @ actions-008f575c92
|
@github-actions crossbow submit test-conda-python-3.8-pandas-nightly test-conda-python-3.9-pandas-upstream_devel |
Revision: 5f8da4a Submitted crossbow builds: ursacomputing/crossbow @ actions-840298ad59
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've reviewed the skips and the opened issues on pandas and all that LGTM. I added a couple comments, one of them (the timestamps one) I am not sure I understand why is required.
"2008-12-28", | ||
"2008-12-29", | ||
"2012-01-01 01:02:03"]) | ||
"2010-01-04T07:35:35.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just curious why are those being updated? are formats like "2008-12-28"
not supported anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That string itself, yes, but not the mixture of different formats in a single list (but I am planning to raise an issue about this, because it seems too pedantic, as all those strings are ISO strings)
@@ -36,7 +36,7 @@ else | |||
fi | |||
|
|||
if [ "${pandas}" = "upstream_devel" ]; then | |||
pip install git+https://github.com/pandas-dev/pandas.git --no-build-isolation | |||
pip install git+https://github.com/pandas-dev/pandas.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder why we did use --no-build-isolation
in the first place. LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think just to be more efficient (all dependencies like numpy and cython were already installed in the env (to build pyarrow), so no need to install those in an isolation build environment). But now pandas started to depend on versioneer
as build-time dependency (instead of vendoring it), so this is the cleanest solution (otherwise we would have to install versioneer first)
Benchmark runs are scheduled for baseline = 54c487b and contender = 1e15f07. 1e15f07 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
['Python', 'R'] benchmarks have high level of regressions. |
…ly skip tests) (apache#15048) Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com> Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
No description provided.