Skip to content

Conversation

@benibus
Copy link
Contributor

@benibus benibus commented Dec 5, 2022

@github-actions
Copy link

github-actions bot commented Dec 5, 2022

@github-actions
Copy link

github-actions bot commented Dec 5, 2022

⚠️ GitHub issue #14842 has been automatically assigned in GitHub to PR creator.

@github-actions
Copy link

github-actions bot commented Dec 5, 2022

⚠️ GitHub issue #14842 has no components, please add labels for components.

@pitrou
Copy link
Member

pitrou commented Dec 5, 2022

Two things:

  1. the parser isn't very strict either, perhaps we can improve it to return an error here?
>>> json.read_json(pa.py_buffer(b"""}"""))
pyarrow.Table

----
  1. the error message could be better, for example "invalid data at end of document"

@benibus
Copy link
Contributor Author

benibus commented Dec 5, 2022

Thanks, @pitrou. This should be all set for a second look.

Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @benibus !

@pitrou pitrou merged commit 2f945c7 into apache:master Dec 5, 2022
@ursabot
Copy link

ursabot commented Dec 6, 2022

Benchmark runs are scheduled for baseline = fb58d89 and contender = 2f945c7. 2f945c7 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.23% ⬆️0.03%] test-mac-arm
[Finished ⬇️0.27% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.28% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 2f945c72 ec2-t3-xlarge-us-east-2
[Finished] 2f945c72 test-mac-arm
[Finished] 2f945c72 ursa-i9-9960x
[Finished] 2f945c72 ursa-thinkcentre-m75q
[Finished] fb58d894 ec2-t3-xlarge-us-east-2
[Finished] fb58d894 test-mac-arm
[Finished] fb58d894 ursa-i9-9960x
[Finished] fb58d894 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[C++] Propagate some errors in JSON chunker

3 participants