Skip to content

ARROW-1720: [Python] Implement bounds check in chunk getter #1243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

ARROW-1720: [Python] Implement bounds check in chunk getter #1243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bda7f4c
BUG: Implement bounds check in chunk getter
Licht-T Oct 24, 2017
cabdd43
TST: Add bounds check tests for chunk getter
Licht-T Oct 24, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions python/pyarrow/table.pxi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,10 @@ cdef class ChunkedArray:
pyarrow.Array
"""
self._check_nullptr()

if i >= self.num_chunks or i < 0:
raise IndexError('Chunk index out of range.')

return pyarrow_wrap_array(self.chunked_array.chunk(i))

def iterchunks(self):
Expand Down
6 changes: 6 additions & 0 deletions python/pyarrow/tests/test_table.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,12 @@ def test_table_basics():
for chunk in col.data.iterchunks():
assert chunk is not None

with pytest.raises(IndexError):
col.data.chunk(-1)

with pytest.raises(IndexError):
col.data.chunk(col.data.num_chunks)


def test_table_from_arrays_invalid_names():
data = [
Expand Down