-
Notifications
You must be signed in to change notification settings - Fork 3.9k
ARROW-255: Finalize Dictionary representation #119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -84,6 +84,10 @@ table Field { | |
| name: string; | ||
| nullable: bool; | ||
| type: Type; | ||
| // present only if the field is dictionary encoded | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. do you want to remove/update the TODO ~line 169?
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. One thing that isn't immediately obvious to me is the exact structure of the DictionaryBatch message, so it would be good to clarify this where there is that TODO. Is each DictionaryBatch constrained to only contain the dictionary for a single vector/array? If a DictionaryBatch can contain the dictionaries for multiple arrays (which seems complicated) then some more specification is needed.
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I will add DictionaryBatch description. I vote for single dictionary per DictionaryBatch. This is simpler and the overhead of the DictionaryBatch header is minimal. |
||
| // will point to a dictionary provided by a DictionaryBatch message | ||
| dictionary: long; | ||
| // children apply only to Nested data types like Struct, List and Union | ||
| children: [Field]; | ||
| } | ||
|
|
||
|
|
@@ -165,8 +169,8 @@ table RecordBatch { | |
| /// For sending dictionary encoding information. Any Field can be | ||
| /// dictionary-encoded, but in this case none of its children may be | ||
| /// dictionary-encoded. | ||
| /// There is one dictionary batch per dictionary | ||
| /// | ||
| /// TODO(wesm): To be documented in more detail | ||
|
|
||
| table DictionaryBatch { | ||
| id: long; | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
an example to point at would be helpful here I think.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As an example, you could have the following data:
In dictionary-encoded form, this could appear as:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will add