-
Notifications
You must be signed in to change notification settings - Fork 3.9k
ARROW-13156 [R] bindings for str_count #11473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor point, but spot on with the approach.
Co-authored-by: Nic <thisisnic@gmail.com>
Co-authored-by: Ian Cook <ianmcook@gmail.com>
…-13156_str_count_bindings
…-13156_str_count_bindings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it needs a run through the styler but otherwise looks good
|
@github-actions autotune |
remove NEWS.md bullet point as we're in the immediate pre-release period Co-authored-by: Ian Cook <ianmcook@gmail.com>
Co-authored-by: Ian Cook <ianmcook@gmail.com>
|
Benchmark runs are scheduled for baseline = d234a2b and contender = 9ce3440. 9ce3440 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Closes #11473 from dragosmg/ARROW-13156_str_count_bindings Lead-authored-by: Dragos Moldovan-Grünfeld <dragos.mold@gmail.com> Co-authored-by: Dragoș Moldovan-Grünfeld <dragos.mold@gmail.com> Signed-off-by: Nic Crane <thisisnic@gmail.com>
No description provided.