Skip to content

Conversation

@dragosmg
Copy link
Contributor

No description provided.

@github-actions
Copy link

@dragosmg dragosmg marked this pull request as ready for review October 20, 2021 08:51
Copy link
Member

@thisisnic thisisnic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor point, but spot on with the approach.

dragosmg and others added 2 commits October 20, 2021 10:45
Co-authored-by: Nic <thisisnic@gmail.com>
@dragosmg dragosmg requested a review from thisisnic October 20, 2021 09:54
dragosmg and others added 2 commits October 20, 2021 14:45
Co-authored-by: Ian Cook <ianmcook@gmail.com>
@dragosmg dragosmg requested a review from ianmcook October 20, 2021 14:23
Copy link
Member

@thisisnic thisisnic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it needs a run through the styler but otherwise looks good

@thisisnic
Copy link
Member

@github-actions autotune

dragosmg and others added 2 commits October 21, 2021 17:25
remove NEWS.md bullet point as we're in the immediate pre-release period

Co-authored-by: Ian Cook <ianmcook@gmail.com>
Co-authored-by: Ian Cook <ianmcook@gmail.com>
@thisisnic thisisnic closed this in 9ce3440 Oct 22, 2021
@ElenaHenderson
Copy link
Contributor

ElenaHenderson commented Oct 22, 2021

Benchmark runs are scheduled for baseline = d234a2b and contender = 9ce3440. 9ce3440 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Scheduled] ursa-i9-9960x
[Finished ⬇️0.09% ⬆️0.04%] ursa-thinkcentre-m75q
Supported benchmarks:
ursa-i9-9960x: langs = Python, R, JavaScript
ursa-thinkcentre-m75q: langs = C++, Java
ec2-t3-xlarge-us-east-2: cloud = True

kou pushed a commit that referenced this pull request Nov 10, 2021
Closes #11473 from dragosmg/ARROW-13156_str_count_bindings

Lead-authored-by: Dragos Moldovan-Grünfeld <dragos.mold@gmail.com>
Co-authored-by: Dragoș Moldovan-Grünfeld <dragos.mold@gmail.com>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
@dragosmg dragosmg deleted the ARROW-13156_str_count_bindings branch December 6, 2021 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants