ARROW-1600: [C++] Add Buffer constructor that wraps std::string #1147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Ic41686a276f35c61f4fa0aca9f79f2b4c3e91482
cpcloud
approved these changes
Sep 29, 2017
cpp/src/arrow/buffer-test.cc
Outdated
| @@ -46,6 +46,14 @@ TEST_F(TestBuffer, IsMutableFlag) { | |||
| ASSERT_TRUE(pbuf.is_mutable()); | |||
| } | |||
|
|
|||
| TEST_F(TestBuffer, FromStdString) { | |||
There was a problem hiding this comment.
Does this need to be TEST_F or can it just be TEST? It doesn't appear to be using any of the members of TestBuffer.
There was a problem hiding this comment.
I removed the fixture and made everything TEST since none of them were using it
| /// \param[in] data a memory buffer | ||
| /// \param[in] size buffer size | ||
| /// | ||
| /// \note The passed memory must be kept alive through some other means |
There was a problem hiding this comment.
Would ASAN be able to detect this kind of lifetime error?
There was a problem hiding this comment.
I think so, and you would segfault if you tried accessing the memory that had already been freed
Change-Id: If2e103879b5627c12b717eab459a248b0b89cf20
wesm
added a commit
to wesm/arrow
that referenced
this pull request
Oct 3, 2017
Many other libraries interchange binary data with `std::string`. This makes it easy to wrap such data in an `arrow::Buffer`. It may be worth adding a function that creates a buffer from a string, but owns its memory. I also deprecated `arrow::GetBufferFromString`, which shouldn't have been public in the first place, since the new ctor is more general Author: Wes McKinney <wes.mckinney@twosigma.com> Closes apache#1147 from wesm/ARROW-1600 and squashes the following commits: f60f502 [Wes McKinney] Remove TestBuffer fixture 644bf2b [Wes McKinney] Add Buffer ctor that wraps std::string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many other libraries interchange binary data with
std::string. This makes it easy to wrap such data in anarrow::Buffer.It may be worth adding a function that creates a buffer from a string, but owns its memory.
I also deprecated
arrow::GetBufferFromString, which shouldn't have been public in the first place, since the new ctor is more general