Skip to content

ARROW-13881: [C++][FlightRPC][Packaging] Ensure Flight is packaged with advanced TLS options on Windows - #11077

Closed
lidavidm wants to merge 1 commit into
apache:masterfrom
lidavidm:arrow-13881
Closed

ARROW-13881: [C++][FlightRPC][Packaging] Ensure Flight is packaged with advanced TLS options on Windows#11077
lidavidm wants to merge 1 commit into
apache:masterfrom
lidavidm:arrow-13881

Conversation

@lidavidm

@lidavidm lidavidm commented Sep 3, 2021

Copy link
Copy Markdown
Member

No description provided.

@lidavidm

lidavidm commented Sep 3, 2021

Copy link
Copy Markdown
Member Author

@github-actions crossbow submit conda-win-vs2017-py39

@github-actions

github-actions Bot commented Sep 3, 2021

Copy link
Copy Markdown

https://issues.apache.org/jira/browse/ARROW-13881

@github-actions

github-actions Bot commented Sep 3, 2021

Copy link
Copy Markdown

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@lidavidm

lidavidm commented Sep 3, 2021

Copy link
Copy Markdown
Member Author

The last passing build for the Windows/Conda builds don't detect TlsCredentialsOptions: https://dev.azure.com/ursacomputing/crossbow/_build/results?buildId=10962&view=logs&j=4c86bc1b-1091-5192-4404-c74dfaad23e7&t=1e0e7149-0c33-565b-af41-050b54dd61be&l=467

This PR sets the flag to fail if not found for the Windows builds too, and tries to fix the detection.

@github-actions

github-actions Bot commented Sep 3, 2021

Copy link
Copy Markdown

Revision: 77f448a

Submitted crossbow builds: ursacomputing/crossbow @ actions-815

Task Status
conda-win-vs2017-py39 Azure

@lidavidm
lidavidm marked this pull request as ready for review September 3, 2021 16:08
@lidavidm
lidavidm requested a review from kszucs September 7, 2021 17:10
@pitrou

pitrou commented Sep 16, 2021

Copy link
Copy Markdown
Member

@github-actions crossbow submit -g wheel

@github-actions

github-actions Bot commented Sep 16, 2021

Copy link
Copy Markdown

Revision: 77f448a

Submitted crossbow builds: ursacomputing/crossbow @ actions-845

Task Status
wheel-macos-big-sur-cp39-arm64 Github Actions
wheel-macos-big-sur-cp39-universal2 Github Actions
wheel-macos-big-sur-py38-arm64 Github Actions
wheel-macos-high-sierra-cp36-amd64 Github Actions
wheel-macos-high-sierra-cp37-amd64 Github Actions
wheel-macos-high-sierra-cp38-amd64 Github Actions
wheel-macos-high-sierra-cp39-amd64 Github Actions
wheel-macos-mavericks-cp36-amd64 Github Actions
wheel-macos-mavericks-cp37-amd64 Github Actions
wheel-macos-mavericks-cp38-amd64 Github Actions
wheel-macos-mavericks-cp39-amd64 Github Actions
wheel-manylinux2010-cp36-amd64 Github Actions
wheel-manylinux2010-cp37-amd64 Github Actions
wheel-manylinux2010-cp38-amd64 Github Actions
wheel-manylinux2010-cp39-amd64 Github Actions
wheel-manylinux2014-cp36-amd64 Github Actions
wheel-manylinux2014-cp36-arm64 TravisCI
wheel-manylinux2014-cp37-amd64 Github Actions
wheel-manylinux2014-cp37-arm64 TravisCI
wheel-manylinux2014-cp38-amd64 Github Actions
wheel-manylinux2014-cp38-arm64 TravisCI
wheel-manylinux2014-cp39-amd64 Github Actions
wheel-manylinux2014-cp39-arm64 TravisCI
wheel-windows-cp36-amd64 Github Actions
wheel-windows-cp37-amd64 Github Actions
wheel-windows-cp38-amd64 Github Actions
wheel-windows-cp39-amd64 Github Actions

pitrou
pitrou approved these changes Sep 16, 2021
View reviewed changes

@pitrou pitrou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. The macOS wheel build failures look unrelated.

@pitrou pitrou closed this in 1d139fe Sep 16, 2021
ViniciusSouzaRoque pushed a commit to s1mbi0se/arrow that referenced this pull request Oct 20, 2021
@lidavidm @ViniciusSouzaRoque
ARROW-13881: [C++][FlightRPC][Packaging] Ensure Flight is packaged wi…
5bcaa41 
…th advanced TLS options on Windows

Closes apache#11077 from lidavidm/arrow-13881

Authored-by: David Li <li.davidm96@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
@h-vetinari h-vetinari mentioned this pull request Sep 12, 2022
Merged
@asfimport asfimport mentioned this pull request Sep 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pitrou pitrou pitrou approved these changes
@kszucs kszucs Awaiting requested review from kszucs

Assignees

No one assigned

Labels

Component: C++ Component: FlightRPC

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lidavidm @pitrou