ARROW-13157: [C++][Python] Add find_substring_regex kernel and implement ignore_case for find_substring #10597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So this implements a |
|
Please go ahead! Sorry, once I added ignore_case using RE2, I figured a find_substring_regex was basically no additional effort, but I should've updated the JIRA. |
ianmcook
changed the title
pitrou
approved these changes
Jun 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
find_substring_regexkernel and adds support for case insensitivity to thefind_substringkernel.RE2 only returns the match position if you have a capture group. Hence we have to modify the supplied regex. For literal patterns, we have to use RE2::QuoteMeta instead of setting the literal flag on the regex.