Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-13003: [C++] Fix key map unaligned access #10489

Closed
wants to merge 1 commit into from

Conversation

cyb70289
Copy link
Contributor

@cyb70289 cyb70289 commented Jun 9, 2021

No description provided.

@cyb70289 cyb70289 marked this pull request as draft June 9, 2021 08:10
@cyb70289
Copy link
Contributor Author

cyb70289 commented Jun 9, 2021

@github-actions crossbow submit test-ubuntu-18.04-r-sanitizer

@github-actions
Copy link

github-actions bot commented Jun 9, 2021

@github-actions
Copy link

github-actions bot commented Jun 9, 2021

Revision: 7c073cd

Submitted crossbow builds: ursacomputing/crossbow @ actions-490

Task Status
test-ubuntu-18.04-r-sanitizer Azure

@cyb70289 cyb70289 changed the title ARROW-13003: [C++] Fix key map unaligned access [WIP] ARROW-13003: [C++] Fix key map unaligned access Jun 9, 2021
@cyb70289
Copy link
Contributor Author

cyb70289 commented Jun 9, 2021

@github-actions crossbow submit test-ubuntu-18.04-r-sanitizer

@github-actions
Copy link

github-actions bot commented Jun 9, 2021

Revision: 7c073cd

Submitted crossbow builds: ursacomputing/crossbow @ actions-491

Task Status
test-ubuntu-18.04-r-sanitizer Azure

@cyb70289 cyb70289 changed the title [WIP] ARROW-13003: [C++] Fix key map unaligned access ARROW-13003: [C++] Fix key map unaligned access Jun 9, 2021
@cyb70289 cyb70289 marked this pull request as ready for review June 9, 2021 14:13
@cyb70289 cyb70289 requested a review from pitrou June 9, 2021 14:22
@pitrou pitrou requested a review from bkietz June 9, 2021 17:48
@pitrou
Copy link
Member

pitrou commented Jun 15, 2021

Rebased.

@pitrou
Copy link
Member

pitrou commented Jun 15, 2021

@ursabot please benchmark

@ursabot
Copy link

ursabot commented Jun 15, 2021

Benchmark runs are scheduled for baseline = 4b3f6c3 and contender = 1cce371. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2 (mimalloc)
[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x (mimalloc)
[Finished ⬇️0.1% ⬆️0.1%] ursa-thinkcentre-m75q (mimalloc)

@pitrou pitrou closed this in 889291b Jun 15, 2021
@cyb70289 cyb70289 deleted the 13003-unaligned-access branch June 15, 2021 23:58
sjperkins pushed a commit to sjperkins/arrow that referenced this pull request Jun 23, 2021
Closes apache#10489 from cyb70289/13003-unaligned-access

Authored-by: Yibo Cai <yibo.cai@arm.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants