Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-638: [C++] Complex Number Support #10452

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

sjperkins
Copy link
Contributor

xref https://issues.apache.org/jira/browse/ARROW-638

Added COMPLEX_FLOAT and COMPLEX_DOUBLE types to the flatbuffers definition in feather.fbs as an initial stab.

This is a draft and I've some questions before proceeding foreward:

  • Complex valued types are standard types so my impression would be that base types should exist for them in Arrow.
  • But this looks like it may be a breaking format change (V5 to V6). Is this undesirable?
  • Alternatively, what would be lost by implementing this as an C++ Extension Type?

@sjperkins sjperkins marked this pull request as draft June 4, 2021 14:16
@github-actions
Copy link

github-actions bot commented Jun 4, 2021

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW

Opening JIRAs ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename pull request title in the following format?

ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

@pitrou
Copy link
Member

pitrou commented Jun 7, 2021

I think it would be best to start a discussion on the dev mailing-list to gauge interest and support for this. @sjperkins Do you want to do it?

@kou kou changed the title [ARROW-638]: [C++] Complex Number Support ARROW-638: [C++] Complex Number Support Jun 8, 2021
@github-actions
Copy link

github-actions bot commented Jun 8, 2021

@sjperkins
Copy link
Contributor Author

#10565 contains the PR implementing Complex Numbers as Extension Types

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants