Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R] AWS SDK fails to build on one of CRAN's M1 builders #43735

Closed
jonkeane opened this issue Aug 17, 2024 · 3 comments
Closed

[R] AWS SDK fails to build on one of CRAN's M1 builders #43735

jonkeane opened this issue Aug 17, 2024 · 3 comments
Assignees
Milestone

Comments

@jonkeane
Copy link
Member

Describe the bug, including details regarding any error messages, version, and platform.

I get a two-week email from CRAN

[ 77%] Building CXX object aws-cpp-sdk-core/CMakeFiles/aws-cpp-sdk-core.dir/source/utils/json/JsonSerializer.cpp.o

-- stderr output is:
make[4]: warning: jobserver unavailable: using -j1.  Add `+' to parent make rule.
�[1m/var/folders/pk/n4bndnt1287ctrd_ftthnnnr0000gp/T/Rtmp6EMNas/working_dir/RtmpCm6S3O/file1379e2ea5ce6f/awssdk_ep-prefix/src/awssdk_ep/aws-cpp-sdk-core/source/net/linux-shared/SimpleUDP.cpp:241:20: �[0m�[0;1;31merror: �[0m�[1mimplicit conversion loses integer precision: 'ssize_t' (aka 'long') to 'int' [-Werror,-Wshorten-64-to-32]�[0m
  241 |             return send(GetUnderlyingSocket(), data, dataLen, 0);�[0m
      | �[0;1;32m            ~~~~~~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
�[0m�[1m/var/folders/pk/n4bndnt1287ctrd_ftthnnnr0000gp/T/Rtmp6EMNas/working_dir/RtmpCm6S3O/file1379e2ea5ce6f/awssdk_ep-prefix/src/awssdk_ep/aws-cpp-sdk-core/source/net/linux-shared/SimpleUDP.cpp:248:24: �[0m�[0;1;31merror: �[0m�[1mimplicit conversion loses integer precision: 'ssize_t' (aka 'long') to 'int' [-Werror,-Wshorten-64-to-32]�[0m
  248 |                 return send(GetUnderlyingSocket(), data, dataLen, 0);�[0m
      | �[0;1;32m                ~~~~~~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
�[0m�[1m/var/folders/pk/n4bndnt1287ctrd_ftthnnnr0000gp/T/Rtmp6EMNas/working_dir/RtmpCm6S3O/file1379e2ea5ce6f/awssdk_ep-prefix/src/awssdk_ep/aws-cpp-sdk-core/source/net/linux-shared/SimpleUDP.cpp:252:24: �[0m�[0;1;31merror: �[0m�[1mimplicit conversion loses integer precision: 'ssize_t' (aka 'long') to 'int' [-Werror,-Wshorten-64-to-32]�[0m
  252 |                 return sendto(GetUnderlyingSocket(), data, dataLen, 0, address, static_cast<socklen_t>(addressLength));�[0m
      | �[0;1;32m                ~~~~~~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
�[0m�[1m/var/folders/pk/n4bndnt1287ctrd_ftthnnnr0000gp/T/Rtmp6EMNas/working_dir/RtmpCm6S3O/file1379e2ea5ce6f/awssdk_ep-prefix/src/awssdk_ep/aws-cpp-sdk-core/source/net/linux-shared/SimpleUDP.cpp:260:24: �[0m�[0;1;31merror: �[0m�[1mimplicit conversion loses integer precision: 'ssize_t' (aka 'long') to 'int' [-Werror,-Wshorten-64-to-32]�[0m
  260 |                 return send(GetUnderlyingSocket(), data, dataLen, 0);�[0m
      | �[0;1;32m                ~~~~~~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
�[0m�[1m/var/folders/pk/n4bndnt1287ctrd_ftthnnnr0000gp/T/Rtmp6EMNas/working_dir/RtmpCm6S3O/file1379e2ea5ce6f/awssdk_ep-prefix/src/awssdk_ep/aws-cpp-sdk-core/source/net/linux-shared/SimpleUDP.cpp:265:24: �[0m�[0;1;31merror: �[0m�[1mimplicit conversion loses integer precision: 'ssize_t' (aka 'long') to 'int' [-Werror,-Wshorten-64-to-32]�[0m
  265 |                 return sendto(GetUnderlyingSocket(), data, dataLen, 0, reinterpret_cast<sockaddr*>(&addrinfo), sizeof(sockaddr_in6));�[0m
      | �[0;1;32m                ~~~~~~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
�[0m�[1m/var/folders/pk/n4bndnt1287ctrd_ftthnnnr0000gp/T/Rtmp6EMNas/working_dir/RtmpCm6S3O/file1379e2ea5ce6f/awssdk_ep-prefix/src/awssdk_ep/aws-cpp-sdk-core/source/net/linux-shared/SimpleUDP.cpp:270:24: �[0m�[0;1;31merror: �[0m�[1mimplicit conversion loses integer precision: 'ssize_t' (aka 'long') to 'int' [-Werror,-Wshorten-64-to-32]�[0m
  270 |                 return sendto(GetUnderlyingSocket(), data, dataLen, 0, reinterpret_cast<sockaddr*>(&addrinfo), sizeof(sockaddr_in));�[0m
      | �[0;1;32m                ~~~~~~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
�[0m�[1m/var/folders/pk/n4bndnt1287ctrd_ftthnnnr0000gp/T/Rtmp6EMNas/working_dir/RtmpCm6S3O/file1379e2ea5ce6f/awssdk_ep-prefix/src/awssdk_ep/aws-cpp-sdk-core/source/net/linux-shared/SimpleUDP.cpp:276:20: �[0m�[0;1;31merror: �[0m�[1mimplicit conversion loses integer precision: 'ssize_t' (aka 'long') to 'int' [-Werror,-Wshorten-64-to-32]�[0m
  276 |             return recv(GetUnderlyingSocket(), buffer, static_cast<int>(bufferLen), 0);�[0m
      | �[0;1;32m            ~~~~~~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
�[0m�[1m/var/folders/pk/n4bndnt1287ctrd_ftthnnnr0000gp/T/Rtmp6EMNas/working_dir/RtmpCm6S3O/file1379e2ea5ce6f/awssdk_ep-prefix/src/awssdk_ep/aws-cpp-sdk-core/source/net/linux-shared/SimpleUDP.cpp:282:20: �[0m�[0;1;31merror: �[0m�[1mimplicit conversion loses integer precision: 'ssize_t' (aka 'long') to 'int' [-Werror,-Wshorten-64-to-32]�[0m
  282 |             return recvfrom(GetUnderlyingSocket(), buffer, static_cast<int>(bufferLen), 0, address, reinterpret_cast<socklen_t*>(addressLength));�[0m
      | �[0;1;32m            ~~~~~~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
�[0m8 errors generated.
make[6]: *** [aws-cpp-sdk-core/CMakeFiles/aws-cpp-sdk-core.dir/source/net/linux-shared/SimpleUDP.cpp.o] Error 1
make[6]: Target `aws-cpp-sdk-core/CMakeFiles/aws-cpp-sdk-core.dir/build' not remade because of errors.
make[5]: *** [aws-cpp-sdk-core/CMakeFiles/aws-cpp-sdk-core.dir/all] Error 2
make[5]: Target `all' not remade because of errors.
make[4]: *** [all] Error 2

This is new, since we only started building S3 with this release (#42210)

See: https://www.stats.ox.ac.uk/pub/bdr/M1mac/arrow.log

Component(s)

R

@assignUser
Copy link
Member

They must have started adding -Werror to the non R CXXFLAGS on those machines?

@jonkeane
Copy link
Member Author

They have for a long time, but we weren't building the AWS SDK before this.

jonkeane added a commit that referenced this issue Aug 18, 2024
…3736)

Trying to replicate the issue's on CRAN's M1 machine so that we can fix them.
* GitHub Issue: #43735

Lead-authored-by: Jonathan Keane <jkeane@gmail.com>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Signed-off-by: Jonathan Keane <jkeane@gmail.com>
@jonkeane jonkeane added this to the 18.0.0 milestone Aug 18, 2024
@jonkeane
Copy link
Member Author

Issue resolved by pull request 43736
#43736

jonkeane added a commit that referenced this issue Aug 18, 2024
…3736)

Trying to replicate the issue's on CRAN's M1 machine so that we can fix them.
* GitHub Issue: #43735

Lead-authored-by: Jonathan Keane <jkeane@gmail.com>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Signed-off-by: Jonathan Keane <jkeane@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants