Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java] Gandiva Tests are failing due to linking issues #43576

Open
vibhatha opened this issue Aug 6, 2024 · 7 comments
Open

[Java] Gandiva Tests are failing due to linking issues #43576

vibhatha opened this issue Aug 6, 2024 · 7 comments

Comments

@vibhatha
Copy link
Collaborator

vibhatha commented Aug 6, 2024

Describe the bug, including details regarding any error messages, version, and platform.

At the moment, java-jars CI in Arrow Java is failing due to a Gandiva issue. This CI in green is much needed to determine the accuracy of certain PRs to Java. In order to keep it green, as discussed we are disabling the failing Gandiva tests temporarily. But needs to be re-enabled once the LLVM related issue is resolved.

Component(s)

Java

@jinchengchenghh
Copy link
Contributor

#43639 (comment) This test also needs to be disabled.

@lidavidm
Copy link
Member

@praveenbingo @pravindra you seem to be the last committers to have worked on the Java part of Gandiva; do you have any idea about this issue?

@vibhatha vibhatha changed the title [Java] Gandiva Tests are failure related to Gandiva [Java] Gandiva Tests are failing due to linking issues Sep 6, 2024
@vibhatha
Copy link
Collaborator Author

vibhatha commented Sep 6, 2024

Most of the failing tests are due to the Could not create LLJIT instance issue [1]. Also, the ProjectTest is mainly failing once. So it would be better to disable the overall test suite and re-enable it once this has been properly fixed.

[1] https://github.com/apache/arrow/actions/runs/10731577229/job/29761887531?pr=43978#step:7:20331

lidavidm pushed a commit that referenced this issue Sep 10, 2024
)

### Rationale for this change

Gandiva tests are failing due to a linking issue and it is failing the Java CIs. But for most of the made PRs, we cannot verify the overall workflow given that those PRs are independent of the Gandiva component. 

### What changes are included in this PR?

This PR disables such failing tests temporarily such that once the Gandiva issue is fixed, re-enabling the tests. 
Re-enabling task will be tracked using #43981

### Are these changes tested?

Yes, by existing CIs and tests.

### Are there any user-facing changes?

No
* GitHub Issue: #43576

Authored-by: Vibhatha Lakmal Abeykoon <vibhatha@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
@lidavidm
Copy link
Member

@laurentgo do you have any colleagues who might know what's up with Gandiva?

khwilson pushed a commit to khwilson/arrow that referenced this issue Sep 14, 2024
apache#43978)

### Rationale for this change

Gandiva tests are failing due to a linking issue and it is failing the Java CIs. But for most of the made PRs, we cannot verify the overall workflow given that those PRs are independent of the Gandiva component. 

### What changes are included in this PR?

This PR disables such failing tests temporarily such that once the Gandiva issue is fixed, re-enabling the tests. 
Re-enabling task will be tracked using apache#43981

### Are these changes tested?

Yes, by existing CIs and tests.

### Are there any user-facing changes?

No
* GitHub Issue: apache#43576

Authored-by: Vibhatha Lakmal Abeykoon <vibhatha@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
zeroshade pushed a commit to zeroshade/arrow that referenced this issue Sep 30, 2024
apache#43978)

### Rationale for this change

Gandiva tests are failing due to a linking issue and it is failing the Java CIs. But for most of the made PRs, we cannot verify the overall workflow given that those PRs are independent of the Gandiva component. 

### What changes are included in this PR?

This PR disables such failing tests temporarily such that once the Gandiva issue is fixed, re-enabling the tests. 
Re-enabling task will be tracked using apache#43981

### Are these changes tested?

Yes, by existing CIs and tests.

### Are there any user-facing changes?

No
* GitHub Issue: apache#43576

Authored-by: Vibhatha Lakmal Abeykoon <vibhatha@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
@raulcd
Copy link
Member

raulcd commented Oct 9, 2024

I've moved this to 19.0.0, let me know if this should be a blocker for the release.

@raulcd raulcd modified the milestones: 18.0.0, 19.0.0 Oct 9, 2024
@lidavidm
Copy link
Member

lidavidm commented Oct 9, 2024

It's possible we're going to ship Gandiva in a known-broken state, so we should just highlight it in the release notes

@vibhatha
Copy link
Collaborator Author

+1 for this. I think that makes sense and a sub optimal solution for the problem we have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants