Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Python] 17.0.0 wrongly installs multiple stray directories into site-packages #43299

Closed
mgorny opened this issue Jul 17, 2024 · 4 comments
Closed

[Python] 17.0.0 wrongly installs multiple stray directories into site-packages #43299

mgorny opened this issue Jul 17, 2024 · 4 comments
Assignees
@raulcd
Labels
Component: Python Priority: Blocker Marks a blocker for the release Type: bug
Milestone
18.0.0

Comments

@mgorny
Copy link
Contributor

mgorny commented Jul 17, 2024

Describe the bug, including details regarding any error messages, version, and platform.

$ pip install pyarrow
Collecting pyarrow
  Downloading pyarrow-17.0.0-cp312-cp312-manylinux_2_28_x86_64.whl.metadata (3.3 kB)
Collecting numpy>=1.16.6 (from pyarrow)
  Using cached numpy-2.0.0-cp312-cp312-manylinux_2_17_x86_64.manylinux2014_x86_64.whl.metadata (60 kB)
Downloading pyarrow-17.0.0-cp312-cp312-manylinux_2_28_x86_64.whl (39.9 MB)
   ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 39.9/39.9 MB 11.0 MB/s eta 0:00:00
Using cached numpy-2.0.0-cp312-cp312-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (19.0 MB)
Installing collected packages: numpy, pyarrow
Successfully installed numpy-2.0.0 pyarrow-17.0.0
$ ls .venv/lib/python3.12/site-packages/
benchmarks     examples  numpy-2.0.0.dist-info  pip                   pyarrow                   scripts
cmake_modules  numpy     numpy.libs             pip-24.1.2.dist-info  pyarrow-17.0.0.dist-info

Note that it wrongly installed benchmarks, cmake_modules, examples and scripts as top-level Python packages.

Component(s)

Python
raulcd added a commit to raulcd/arrow that referenced this issue Jul 18, 2024
@raulcd
apacheGH-43299: [Release][Packaging] Only include pyarrow and pyarrow…
888a5ae 
….* when finding packages on setuptools
@github-actions github-actions bot mentioned this issue Jul 18, 2024
Merged
@raulcd
Copy link
Member

raulcd commented Jul 18, 2024

Hi,

Thanks for reporting. It seems we added this bug when migrating from setup.py to pyproject.toml

@timkpaine
Copy link
Contributor

duplicate of #43280

@timkpaine timkpaine mentioned this issue Jul 19, 2024
Closed
@pitrou pitrou added this to the 18.0.0 milestone Aug 8, 2024
@pitrou pitrou added the Priority: Blocker Marks a blocker for the release label Aug 8, 2024
@pitrou pitrou mentioned this issue Aug 8, 2024
Closed
raulcd added a commit to raulcd/arrow that referenced this issue Sep 3, 2024
@raulcd
apacheGH-43299: [Release][Packaging] Only include pyarrow and pyarrow…
c6661e1 
….* when finding packages on setuptools
jorisvandenbossche pushed a commit that referenced this issue Sep 5, 2024
@raulcd @pitrou
GH-43299: [Release][Packaging] Only include pyarrow folder when findi…
f545b90 
…ng packages on setuptools (#43325)

### Rationale for this change

Currently we include everything when building wheels, see:
```
$ pip install pyarrow
Collecting pyarrow
  Downloading pyarrow-17.0.0-cp310-cp310-manylinux_2_28_x86_64.whl (39.9 MB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 39.9/39.9 MB 33.8 MB/s eta 0:00:00
Collecting numpy>=1.16.6
  Using cached numpy-2.0.0-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (19.3 MB)
Installing collected packages: numpy, pyarrow
Successfully installed numpy-2.0.0 pyarrow-17.0.0
(test-env)  $ ls test-env/lib/python3.10/site-packages/
benchmarks/                  distutils-precedence.pth     numpy-2.0.0.dist-info/       pip-22.0.2.dist-info/        pyarrow-17.0.0.dist-info/    setuptools-59.6.0.dist-info/ 
cmake_modules/               examples/                    numpy.libs/                  pkg_resources/               scripts/                     
_distutils_hack/             numpy/                       pip/                         pyarrow/                     setuptools/    
```

### What changes are included in this PR?

Use `include` as seen here: https://setuptools.pypa.io/en/latest/userguide/package_discovery.html#finding-simple-packages

### Are these changes tested?

Will check via the build wheel on CI

### Are there any user-facing changes?

No and yes :)
We will remove unnecessary files
* GitHub Issue: #43299

Lead-authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Co-authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
@jorisvandenbossche
Copy link
Member

Issue resolved by pull request 43325
#43325

@mgorny
Copy link
Contributor Author

mgorny commented Sep 5, 2024

Thanks!

zanmato1984 pushed a commit to zanmato1984/arrow that referenced this issue Sep 6, 2024
@raulcd @pitrou @zanmato1984
apacheGH-43299: [Release][Packaging] Only include pyarrow folder when…
29597b4 
… finding packages on setuptools (apache#43325)

### Rationale for this change

Currently we include everything when building wheels, see:
```
$ pip install pyarrow
Collecting pyarrow
  Downloading pyarrow-17.0.0-cp310-cp310-manylinux_2_28_x86_64.whl (39.9 MB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 39.9/39.9 MB 33.8 MB/s eta 0:00:00
Collecting numpy>=1.16.6
  Using cached numpy-2.0.0-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (19.3 MB)
Installing collected packages: numpy, pyarrow
Successfully installed numpy-2.0.0 pyarrow-17.0.0
(test-env)  $ ls test-env/lib/python3.10/site-packages/
benchmarks/                  distutils-precedence.pth     numpy-2.0.0.dist-info/       pip-22.0.2.dist-info/        pyarrow-17.0.0.dist-info/    setuptools-59.6.0.dist-info/ 
cmake_modules/               examples/                    numpy.libs/                  pkg_resources/               scripts/                     
_distutils_hack/             numpy/                       pip/                         pyarrow/                     setuptools/    
```

### What changes are included in this PR?

Use `include` as seen here: https://setuptools.pypa.io/en/latest/userguide/package_discovery.html#finding-simple-packages

### Are these changes tested?

Will check via the build wheel on CI

### Are there any user-facing changes?

No and yes :)
We will remove unnecessary files
* GitHub Issue: apache#43299

Lead-authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Co-authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
khwilson pushed a commit to khwilson/arrow that referenced this issue Sep 14, 2024
@raulcd @pitrou @khwilson
apacheGH-43299: [Release][Packaging] Only include pyarrow folder when…
caa368e 
… finding packages on setuptools (apache#43325)

### Rationale for this change

Currently we include everything when building wheels, see:
```
$ pip install pyarrow
Collecting pyarrow
  Downloading pyarrow-17.0.0-cp310-cp310-manylinux_2_28_x86_64.whl (39.9 MB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 39.9/39.9 MB 33.8 MB/s eta 0:00:00
Collecting numpy>=1.16.6
  Using cached numpy-2.0.0-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (19.3 MB)
Installing collected packages: numpy, pyarrow
Successfully installed numpy-2.0.0 pyarrow-17.0.0
(test-env)  $ ls test-env/lib/python3.10/site-packages/
benchmarks/                  distutils-precedence.pth     numpy-2.0.0.dist-info/       pip-22.0.2.dist-info/        pyarrow-17.0.0.dist-info/    setuptools-59.6.0.dist-info/ 
cmake_modules/               examples/                    numpy.libs/                  pkg_resources/               scripts/                     
_distutils_hack/             numpy/                       pip/                         pyarrow/                     setuptools/    
```

### What changes are included in this PR?

Use `include` as seen here: https://setuptools.pypa.io/en/latest/userguide/package_discovery.html#finding-simple-packages

### Are these changes tested?

Will check via the build wheel on CI

### Are there any user-facing changes?

No and yes :)
We will remove unnecessary files
* GitHub Issue: apache#43299

Lead-authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Co-authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
@raulcd raulcd mentioned this issue Oct 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raulcd raulcd

Labels
Component: Python Priority: Blocker Marks a blocker for the release Type: bug
Projects
None yet
Milestone
18.0.0
Development

Successfully merging a pull request may close this issue.

GH-43280: [Python] Prune examples and benchmarks folders from release timkpaine/arrow
5 participants
@mgorny @raulcd @jorisvandenbossche @pitrou @timkpaine