Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R] macOS binaries on CRAN are not feature complete #41952

Closed
assignUser opened this issue Jun 4, 2024 · 1 comment
Closed

[R] macOS binaries on CRAN are not feature complete #41952

assignUser opened this issue Jun 4, 2024 · 1 comment
Assignees
@jonkeane
Labels
Component: R
Milestone
17.0.0

Comments

@assignUser
Copy link
Member 

Arrow package version: 16.1.0

Capabilities:

acero      TRUE
dataset    TRUE
substrait FALSE
parquet    TRUE
json       TRUE
s3        FALSE
gcs       FALSE
utf8proc   TRUE
re2        TRUE
snappy     TRUE
gzip      FALSE
brotli    FALSE
zstd      FALSE
lz4        TRUE
lz4_frame  TRUE
lzo       FALSE
bz2       FALSE
jemalloc  FALSE
mimalloc   TRUE

edit: I think this is only possible if LIBARROW_MINIMAL is unset when build_arrow_static.sh is run? Which just is the case if the var is not set as we check for it but only actively set it if not_cran. Not sure why it wouldn't also show like this on the mac builder?

Originally posted by @assignUser in #41647 (comment)
@github-actions github-actions bot mentioned this issue Jun 19, 2024
Merged
jonkeane added a commit that referenced this issue Jun 23, 2024
@jonkeane @nealrichardson
GH-41952: [R] Turn S3 and ZSTD on by default for macOS (#42210)
67bbf84 
Changeup `nixlibs.R` so that we enable S3 and ZSTD by default on CRAN. I've checked this against the CRAN macbuilder to confirm it does work (that's not a guarantee it'll work on other CRAN maintained macOS builders, but a good indication).

It also removes gcs from the list of features we expect to be on and warn folks about if it is not.

### Rationale for this change

So that our builds are more fully featured.

### What changes are included in this PR?

Enable `ARROW_S3` by default when building form source on macOS.

### Are these changes tested?

Existing CI should not fail.

### Are there any user-facing changes?

Getting Arrow from the canonical repository would be more fully featured.
* GitHub Issue: #41952

Lead-authored-by: Jonathan Keane <jkeane@gmail.com>
Co-authored-by: Neal Richardson <neal.p.richardson@gmail.com>
Signed-off-by: Jonathan Keane <jkeane@gmail.com>
@jonkeane
Copy link
Member

Issue resolved by pull request 42210
#42210

@jonkeane jonkeane added this to the 17.0.0 milestone Jun 23, 2024
@grantmcdermott grantmcdermott mentioned this issue Jun 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonkeane jonkeane

Labels
Component: R
Projects
None yet
Milestone
17.0.0
Development

No branches or pull requests
2 participants
@jonkeane @assignUser