Skip to content

Commit

Permalink
ARROW-6962: [C++] [CI] Stop compiling with -Weverything
Browse files Browse the repository at this point in the history
Closes #5713 from pitrou/ARROW-6962 and squashes the following commits:

65a7d64 <Antoine Pitrou> Update comment
b253498 <Antoine Pitrou> Try adding `-Wextra`
04fb645 <Antoine Pitrou> ARROW-6962:   Stop compiling with -Weverything

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
  • Loading branch information
pitrou authored and kszucs committed Oct 24, 2019
1 parent 28d6d97 commit d02f74e
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
3 changes: 2 additions & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,8 @@ matrix:
env:
- ARROW_TRAVIS_FLIGHT=1
- ARROW_TRAVIS_GANDIVA=1
- ARROW_TRAVIS_ORC=1
# Disabled until either ORC-480 or ORC-561 is fixed
- ARROW_TRAVIS_ORC=0
- ARROW_TRAVIS_PARQUET=1
- ARROW_TRAVIS_PLASMA=1
- ARROW_TRAVIS_PYTHON=1
Expand Down
7 changes: 3 additions & 4 deletions cpp/cmake_modules/SetupCxxFlags.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -100,9 +100,8 @@ endif()
# BUILD_WARNING_LEVEL add warning/error compiler flags. The possible values are
# - PRODUCTION: Build with `-Wall` but do not add `-Werror`, so warnings do not
# halt the build.
# - CHECKIN: Imply `-Weverything` with certain pedantic warnings
# disabled. `-Werror` is added in debug builds so that any warnings fail the
# build
# - CHECKIN: Build with `-Wall` and `-Wextra`. Also, add `-Werror` in debug mode
# so that any important warnings fail the build.
# - EVERYTHING: Like `CHECKIN`, but possible extra flags depending on the
# compiler, including `-Wextra`, `-Weverything`, `-pedantic`.
# This is the most aggressive warning level.
Expand Down Expand Up @@ -138,7 +137,7 @@ if("${BUILD_WARNING_LEVEL}" STREQUAL "CHECKIN")
# https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warnings-by-compiler-version
set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} /W3 /wd4365 /wd4267 /wd4838")
elseif("${COMPILER_FAMILY}" STREQUAL "clang")
set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -Weverything -Wdocumentation \
set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -Wall -Wextra -Wdocumentation \
-Wno-c++98-compat \
-Wno-c++98-compat-pedantic -Wno-deprecated -Wno-weak-vtables -Wno-padded \
-Wno-comma -Wno-unused-macros -Wno-unused-parameter -Wno-unused-template -Wno-undef \
Expand Down

0 comments on commit d02f74e

Please sign in to comment.