Fix MakeMaskArray iterating over the end of vector

apache · Oct 17, 2024 · a07ad19 · a07ad19
1 parent 33264a1
commit a07ad19
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/cpp/src/arrow/array/util.cc b/cpp/src/arrow/array/util.cc
@@ -921,9 +921,13 @@ Result<std::shared_ptr<Array>> MakeMaskArray(const std::vector<int64_t>& indices
   BooleanBuilder builder(pool);
   RETURN_NOT_OK(builder.Resize(length));
 
+  auto indices_end = indices.end();
   auto i = indices.begin();
   for (int64_t builder_i = 0; builder_i < length; builder_i++) {
-    if (builder_i == *i) {
+    if (i == indices_end) {
+      RETURN_NOT_OK(builder.AppendValues(static_cast<int64_t>(length - builder.length()), false));
+      break;
+    } else if (builder_i == *i) {
       builder.UnsafeAppend(true);
       i++;
     } else {