Skip to content

feat: parse DataType::Union, DataType::Map, DataType::RunEndEncoded #8765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 4, 2025
Merged

feat: parse DataType::Union, DataType::Map, DataType::RunEndEncoded #8765

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
8fcbdf6
test: add `DataType::Union`
dqkqd Nov 1, 2025
5ed2058
feat: parse `DataType::Union`
dqkqd Nov 1, 2025
0ac757d
refactor: use `parse_field` function
dqkqd Nov 1, 2025
33814fb
test: add `DataType::Map`
dqkqd Nov 2, 2025
a0d9b93
feat: parse `DataType::Map`
dqkqd Nov 2, 2025
b466565
feat: test and parse `DataType::RunEndCoded`
dqkqd Nov 2, 2025
77bafb5
refactor: add `parse_list_field`, remove duplicated codes
dqkqd Nov 2, 2025
3806267
test: add test for empty union, union and struct with one field
dqkqd Nov 2, 2025
fe70331
fix: handle empty `Union`
dqkqd Nov 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion arrow-schema/src/datatype_display.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,8 +139,9 @@ impl fmt::Display for DataType {
Ok(())
}
Self::Union(union_fields, union_mode) => {
write!(f, "Union({union_mode:?}, ")?;
write!(f, "Union({union_mode:?}")?;
if !union_fields.is_empty() {
write!(f, ", ")?;
Copy link
Contributor Author

@dqkqd dqkqd Nov 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allow empty union to be displayed like Union(Dense), instead of Union(Dense, )

let fields_str = union_fields
.iter()
.map(|v| {
Expand Down
Loading
Loading