[Variant] Fix the index of an item in VariantArray in a unit test #8725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apache@63fe99a introduced the new unit test. I believe the index=3 is a typo. It should be =2. Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
Member
Author
friendlymatthew
approved these changes
Oct 27, 2025
Contributor
friendlymatthew
left a comment
friendlymatthew
left a comment
There was a problem hiding this comment.
Thank you @martin-g
alamb
approved these changes
Oct 28, 2025
Contributor
There was a problem hiding this comment.
Thank you @martin-g and @friendlymatthew
I wonder why calling is_null(3)didn't panic 🤔 Maybe it is because the bitmap is within bounds ...
Member
Author
It does not panic because it does not use the index at all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related-to: #8625
Rationale for this change
63fe99a introduced the new unit test.
I believe the index=3 is a typo. It should be =2.
What changes are included in this PR?
Fixed the array index.
Are these changes tested?
The fix is in a unit test.
Are there any user-facing changes?
No.